Conversation
|
This seems good to me, but please look into the travis errors and make sure all the tests pass before merging. It looks like this isn't related to the actual functionality here, but has to do with some missing unrelated WP-API libraries. If you're stuck, ping me and we'll look at it. We just need to make sure Travis is working so we diagnose legitimately non-passing tests in the future. |
|
Please make it such that you can specify the start or end and not have to specify both. I will definitely want to use this to index all posts after a certain date, and there should be no need to have to specify a future date as the end |
bin/wp-cli.php
Outdated
There was a problem hiding this comment.
Please declare this property in the class
|
Tests passing now. I borrowed the travis setup from Fieldmanager. I think I could just remove bin/install-wp-tests.sh as everything is setup in .travis.yml now. |
If you use |
.travis.yml
Outdated
There was a problem hiding this comment.
these versions are all outdated. plus update this to 4.2, 4.3, and master (and remove the 4th version)
|
Looks like we get a bonus modernization of the SP testing framework out of this PR too. Nice work! 🐴 |
tests/test-searching.php
Outdated
There was a problem hiding this comment.
You need to revert the changes to this file. I'm sure there's a reason why you did this, so let's discuss in Slack, but this was very deliberate.
No description provided.