Refactor heartbeat to also record last query time#194
Merged
Conversation
jakewrfoster
previously approved these changes
May 16, 2025
Member
jakewrfoster
left a comment
There was a problem hiding this comment.
little suggestions, but nothing blocking
🍣
|
|
||
| ### 0.5.2 | ||
|
|
||
| * **POSSIBLE BREAKING CHANGE** Refactors `SP_Heartbeat` to store the last time the beat was checked as well as the last time the beat was verified. `SP_Heartbeat::get_last_beat()` previously returned an int, but now returns an array. |
Member
There was a problem hiding this comment.
I'm assuming the possible work around here would be to manually delete this option value?
Contributor
Author
There was a problem hiding this comment.
I'm not following -- do you mean what a plugin/theme currently using SP_Heartbeat::get_last_beat() should do to work around the change?
Co-authored-by: Jake <jake@alley.co>
mboynes
commented
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SP_Heartbeatto store the last time the beat was checked as well as the last time the beat was verified.SP_Heartbeat::get_last_beat()previously returned an int, but now returns an array.Resolves #61, #62