Add the sp_request_response action hook to the SP_API Class#181
Merged
renatonascalves merged 1 commit intorelease/0.5from Jan 10, 2024
Merged
Add the sp_request_response action hook to the SP_API Class#181renatonascalves merged 1 commit intorelease/0.5from
sp_request_response action hook to the SP_API Class#181renatonascalves merged 1 commit intorelease/0.5from
Conversation
srtfisher
approved these changes
Jan 9, 2024
| * @param string $body The body of the request. | ||
| * @param array $request_params Additional parameters. | ||
| */ | ||
| do_action( 'sp_request_response', $result, $url, $method, $body, $request_params ); |
Member
There was a problem hiding this comment.
Is there harm in making this a filter to make it more extendible?
Contributor
Author
There was a problem hiding this comment.
No harm but a filter serves a different purpose than an action. Currently, the nypost uses this action to fire something rather than to change the output.
I guess we need both?!
Member
There was a problem hiding this comment.
I guess we can ignore this for now then until the need arises
Contributor
Author
There was a problem hiding this comment.
I'll introduce it in a separate pr. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow devs to fire an action when a
SP_API()->get_api_endpointrequest is performed.