Merged
Conversation
jakewrfoster
approved these changes
Sep 25, 2023
Member
jakewrfoster
left a comment
There was a problem hiding this comment.
Nothing blocking, but I did have a few questions 🎠 Thanks for hopping on this so quickly!
P.S. I'm not sure if this is shaping up to be a commit to merge as a release, but we should also consider updating the README as part of this PR (or a follow up) so that the work doesn't stray from the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ES 8.0 introduced a number of breaking changes. Those that directly impacted SearchPress were:
_doc/was removed from several API endpoints, like_bulk,_count, and_search.calendar_interval.