Conversation
|
🎉 This is ready for review! 🍡 |
kevinfodness
left a comment
There was a problem hiding this comment.
Nice work. Left a few comments on things to be cleaned up before merge. 🍣
| php: [8.0] | ||
| es_version: [7.17.5] | ||
| multisite: [0] | ||
| wp_version: ["latest"] |
There was a problem hiding this comment.
This is confusing - in our conversation you said the PHP 8 check isn't being run? Is there a way to specify all items in the matrix on the same "level" vs. having some defined here and some in the include section?
There was a problem hiding this comment.
It is being run, ES: 8.3.2 is the one that is not running since there is no support for it yet.
There was a problem hiding this comment.
Is there a way to specify all items in the matrix on the same "level"
The problem I've found with the matrix is that it creates different job configurations outside of my predefined matrix.
The documentation goes more into detail: https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#using-a-matrix-strategy
At one time, I got 40+ job combinations. See here: https://github.com/alleyinteractive/searchpress/actions/runs/2656687756
| sudo sysctl -w vm.max_map_count=262144 | ||
|
|
||
| - name: Set up Elasticsearch | ||
| uses: elastic/elastic-github-actions/elasticsearch@master |
…tive/searchpress into feature/gh-action-unit-test
As titled.
bin/bash files)fixes #145