Clean up SP_Integration with posts_pre_query#138
Merged
srtfisher merged 7 commits intorelease/0.5from Jun 15, 2021
Merged
Conversation
Closed
Contributor
|
Didn't review it in depth but it looks pretty at a high level! Just want to note that this could be a breaking change for some, so we'll need to be explicit about that. |
danbowles
approved these changes
Dec 1, 2020
mboynes
approved these changes
Dec 1, 2020
Contributor
mboynes
left a comment
There was a problem hiding this comment.
It's glorious to see how much this improves the integration. Wanna do the same thing for ES_WP_Query? 😄
| */ | ||
| function test_admin() { | ||
| SP_Admin(); | ||
| $this->assertInstanceOf( SP_Admin::class, SP_Admin() ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #100. Moves the SearchPress integration to
posts_pre_query.