Merged
Conversation
mboynes
reviewed
Apr 17, 2020
lib/class-sp-admin.php
Outdated
| <p> | ||
| <label for="sp_password"><?php esc_html_e( 'Password (optional):', 'searchpress' ); ?></label> | ||
| <input type="password" name="sp_password" id="sp_password" style="width:100%;max-width:500px" /> | ||
| <br /><?php esc_html_e( 'Stored password is encoded and will not load back into this form.', 'searchpress' ); ?> |
Contributor
There was a problem hiding this comment.
it's encoded, but in a way that can be decoded, so we can still work with it. @kevinfodness has some good art for password updates in WP forms.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an admin GUI for:
Index
Username
Password
Authorization Header
The password is not stored in plain text. Instead base64_encode(username:password) is stored.
Addresses #18