feat(repo): github profile url should be valid#268
Merged
Berkmann18 merged 2 commits intoall-contributors:masterfrom Jun 7, 2020
k3nsei:feature/validate-profile-url
Merged
feat(repo): github profile url should be valid#268Berkmann18 merged 2 commits intoall-contributors:masterfrom k3nsei:feature/validate-profile-url
Berkmann18 merged 2 commits intoall-contributors:masterfrom
k3nsei:feature/validate-profile-url
Conversation
Contributor
Author
|
@Berkmann18 please do code review |
Berkmann18
approved these changes
Jun 7, 2020
Member
Berkmann18
left a comment
There was a problem hiding this comment.
That looks good to me. Have you tried that on your repo where you originally had the issue?
Contributor
Author
yarn run all-contributors add Silvest89 bug
yarn run v1.22.4
$ /app/projects/ng-in-viewport/node_modules/.bin/all-contributors add Silvest89 bug
Cannot read property 'isValidHttpUrl' of undefined
error Command failed with exit code 1.Don't know why |
Contributor
Author
|
@Berkmann18 I changed import from |
Berkmann18
requested changes
Jun 7, 2020
Contributor
Author
|
@Berkmann18 now all should be ok |
Berkmann18
approved these changes
Jun 7, 2020
Member
|
🎉 This PR is included in version 6.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Contributor profile url should be valid url
Why:
Please see issue #267
How:
Validator was added and used where github profile url is assigned
Checklist: