feat: add suggested solutions to untrusted site message#2060
Merged
Fabien-Chouteau merged 4 commits intoJan 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the error message shown when alr publish fails due to an untrusted origin site. The message now provides context-specific guidance: for private index publishing, it directs users to configure the origins.git.trusted_sites setting, while for community index submissions, it prompts users to open a GitHub issue if they believe the site should be trusted.
- Updated error message format to be more specific and user-friendly
- Added conditional suggested solutions based on whether
--for-private-indexis used - Updated documentation to clarify why community index has restricted trusted sites
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/alire/alire-publish.adb | Implements the new error message with context-aware suggestions for untrusted sites |
| src/alire/alire-settings-builtins.ads | Adds clarification about SHA1 vulnerability rationale for community index restrictions |
| testsuite/tests/publish/check-trusted/test.py | Updates test assertions to match new error message format |
| testsuite/tests/publish/private-indexes/test.py | Updates test assertions and adds validation for context-specific suggestions |
| testsuite/tests/publish/ssh-remote-origin/test.py | Updates test assertion to match new error message format |
Contributor
Author
|
The failure looks transient, so ready for review @mosteo. |
AldanTanneo
approved these changes
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1985
When
alr publishfails due to an untrusted origin, the message now has the formor, if
--for-private-indexis specified,PR creation checklist
doc/user-changes.mdhas been updated, if there are user-visible changes.doc/catalog-format-spec.mdhas been updated, if applicable.BREAKING.mdhas been updated for major changes inalr, minor/major in catalog format.