fix: make explicit Git URLs backward compatible#1826
Merged
Conversation
Fabien-Chouteau
approved these changes
Jan 23, 2025
mosteo
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of #1736,
https://host/path.gitURLs are recognised as Git URLs due to the.gitsuffix. Prior to this, however, recognition was inconsistent, so a URL produced byAlire.URI.Make_VCS_Explicitis not necessarily backward compatible. In particular,alr publishwithalr 2.1can produce a manifest whichalr 2.0considers invalid.As mentioned here, this PR changes
Alire.URI.Make_VCS_Explicitto always add agit+, even if there is a.gitsuffix, so thatalr publishproduces backward-compatible manifests.PR creation checklist