Fix traversal of dirs containing troublesome softlinks#1718
Merged
Conversation
ff5b674 to
577a9db
Compare
850e4c4 to
479fc19
Compare
commit 7d8b2cc Author: Alejandro R. Mosteo <amosteo@unizar.es> Date: Fri Aug 2 09:53:22 2024 +0200 Debug trouble with relative path finder commit 0951457 Author: Alejandro R. Mosteo <amosteo@unizar.es> Date: Thu Aug 1 22:32:48 2024 +0200 Use simpler relative path from Den commit 76417fa Author: Alejandro R. Mosteo <amosteo@unizar.es> Date: Thu Aug 1 22:32:09 2024 +0200 Revert "Try with gprbuild<24" This reverts commit b6ca84e. commit f6e0a96 Author: Alejandro R. Mosteo <amosteo@unizar.es> Date: Thu Aug 1 00:04:00 2024 +0200 Repair find relative part output commit 6ad595f Author: Alejandro R. Mosteo <amosteo@unizar.es> Date: Wed Jul 31 23:28:48 2024 +0200 Flush testsuite output at start commit a52e555 Author: Alejandro R. Mosteo <amosteo@unizar.es> Date: Wed Jul 31 18:18:44 2024 +0200 Fix damaged test commit b6ca84e Author: Alejandro R. Mosteo <amosteo@unizar.es> Date: Wed Jul 31 14:16:11 2024 +0200 Try with gprbuild<24 commit 5000210 Author: Alejandro R. Mosteo <amosteo@unizar.es> Date: Wed Jul 31 14:04:07 2024 +0200 Show GNAT/GPRBUILD versions prior to testsuite run
Fabien-Chouteau
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is bugfix/refactor with no behavior changes. Several operations that look for files in subdirectories would bomb in the presence of recursive/broken links.
A new crate (
den) with consistent behavior for softlinks across Unixes/Windows should simplify Alire's own code moving forward. We were previously assuming that Windows doesn't support softlinks (and bothGNAT.OS_LibandGNATCOLLstill do), but this is not true for recent Windows versions with developer mode enabled (which is the case of GitHub runners).