Alr.Commands.Search: change default behavior to include properties#1575
Merged
Conversation
This patch comes from a comment of a user looking for gnatpp in Alire. gnatpp is part of the libabalang_tools crate and a 1.x `alr search gnatpp` returns nothing. The reason that by default only the release name and descriptions are searched. This is quite a bad user interaction. Here we change the default behavior to search in all properties of a release, including tags, executables, website, etc. We also display the list of properties that match the pattern. Searching in names and descriptions only is still possible with the --crates switch.
mosteo
reviewed
Feb 22, 2024
mosteo
approved these changes
Feb 22, 2024
mosteo
left a comment
Member
There was a problem hiding this comment.
Nice feature. I just saw some noisy behavior that could be improved.
2f80399 to
1fa40c4
Compare
1fa40c4 to
48df7c9
Compare
mosteo
approved these changes
Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch comes from a comment of a user looking for gnatpp in Alire. gnatpp is part of the libabalang_tools crate and a 1.x
alr search gnatppreturns nothing. The reason that by default only the release name and descriptions are searched. This is quite a bad user interaction.Here we change the default behavior to search in all properties of a release, including tags, executables, website, etc.
We also display the list of properties that match the pattern.
Searching in names and descriptions only is still possible with the --crates switch.