Offer to fork index instead of failing during publishing#1535
Merged
Conversation
Fabien-Chouteau
approved these changes
Jan 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, we checked that the user fork existed or else errored out during manifest generation, despite the ability to fork on the user's behalf being available later during submission.
This way, if the user's fork doesn't exist, we offer to create it already instead of aborting, and the process continues on.
The inconsistency arose from the fact that in the initial implementation, generating the manifest and automatic submission were two separate invocations, whereas now the latter follows the former during the same invocation.