Report the name of an unreadable directory.#1522
Closed
simonjwright wants to merge 5 commits into
Closed
Conversation
* src/alire/alire-index_on_disk.adb (New_Handler.Process_Local_Index):
If the Path isn't a writable directory (e.g. because it doesn't
exist), add it to the message in Outcome_Failure.
* testsuite/tests/index/local-index-not-found/test.py: as summary.
* testsuite/tests/index/local-index-not-found/test.py: as summary.
* testsuite/tests/index/local-index-not-found/test.py: the input was
"no-such-directory", but the output was "./no-such-directory".
Fix the input to match that.
Contributor
Author
|
Sorry, I’ve no idea how to fix this. |
* testsuite/tests/index/local-index-not-found/test.py (comparator): new.
Use when preparing test condition.
Contributor
Author
|
Sorry, this is just not worth it. Abandoned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on a new external, I tried adding my local alire-index before the community index for testing. The error reported was "Not a readable directory". After 2 hours investigation (gdb ...) I realised that I’d been trying to add
alr-indexrather thanalire-index.This patch (which is in the style of other
Outcome_Failuremessages) would probably have saved that time!