Allow missing configuration values until build#1167
Merged
Conversation
07cbbfa to
c7d7135
Compare
Fabien-Chouteau
left a comment
Member
There was a problem hiding this comment.
The patch looks ok but I am not sure about the solution used here.
In particular I don't like that the config files will be generated but only partially.
Could we skip entirely the config generation on the get step?
Member
Author
|
Changed to avoid generating files in case of incompleteness. Also renamed a |
Fabien-Chouteau
approved these changes
Sep 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way we can normally get/without crates without defaults, but at the time of building the values must be set.
Fixes #1125