Reason for missing releases in solution#1127
Merged
Merged
Conversation
Although other tests already exercise the new feature, this way we have an explicit one in case the others changed at some point.
Fabien-Chouteau
approved these changes
Aug 8, 2022
Fabien-Chouteau
left a comment
Member
There was a problem hiding this comment.
Looks good to me except for the word "unindexed". To me it feels like the crate is available somewhere but not indexed, which might not be the case. Maybe "unknown" would be better.
Member
Author
|
I see your point. Will change it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an internal improvement to the solver so now when a dependency can't be solved it will give the reason (via an extra
:reasonpart after the usualmissed). For example, in the output ofalr with --solve: