Skip to content
This repository was archived by the owner on Oct 23, 2024. It is now read-only.

Fix issue2689 （新版本解析到特定字符后直接触发异常）#2692

Merged
wenshao merged 2 commits intoalibaba:masterfrom
Omega-Ariston:fix-issue2689
Sep 3, 2019
Merged

Fix issue2689 （新版本解析到特定字符后直接触发异常）#2692
wenshao merged 2 commits intoalibaba:masterfrom
Omega-Ariston:fix-issue2689

Conversation

@Omega-Ariston
Copy link
Copy Markdown
Collaborator

@Omega-Ariston Omega-Ariston commented Sep 3, 2019 •
edited by wenshao
Loading

fix issue #2689

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 3, 2019 •
edited
Loading

Codecov Report

Merging #2692 into master will increase coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2692      +/-   ##
============================================
+ Coverage     81.23%   81.24%   +<.01%     
- Complexity     7068     7075       +7     
============================================
  Files           143      143              
  Lines         26399    26402       +3     
  Branches       6311     6312       +1     
============================================
+ Hits          21446    21451       +5     
  Misses         3125     3125              
+ Partials       1828     1826       -2
Impacted Files Coverage Δ Complexity Δ
...ava/com/alibaba/fastjson/parser/JSONLexerBase.java 71.21% <33.33%> (-0.07%) 811 <3> (+3)
...java/com/alibaba/fastjson/parser/ParserConfig.java 83.3% <0%> (+0.16%) 203% <0%> (+1%) ⬆️
...n/java/com/alibaba/fastjson/util/JavaBeanInfo.java 87.84% <0%> (+0.18%) 196% <0%> (+1%) ⬆️
...ava/com/alibaba/fastjson/serializer/DateCodec.java 89.54% <0%> (+1.96%) 38% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c9bede...b44900e. Read the comment docs.

@wenshao wenshao merged commit cda8773 into alibaba:master Sep 3, 2019
@Omega-Ariston Omega-Ariston changed the title Fix issue2689 （反序列化特殊字符串引发OOM异常） Fix issue2689 （新版本解析到特定字符后直接触发异常） Sep 3, 2019
@yeweichen
Copy link
Copy Markdown

yeweichen commented Sep 3, 2019

请问这个修复预计会出现在后续哪个版本的fastjson中？

@Omega-Ariston
Copy link
Copy Markdown
Collaborator Author

Omega-Ariston commented Sep 3, 2019

请问这个修复预计会出现在后续哪个版本的fastjson中？

这几天会发新版本，最晚周末，敬请期待 :)

@Omega-Ariston Omega-Ariston deleted the fix-issue2689 branch September 3, 2019 09:18
@yeweichen
Copy link
Copy Markdown

yeweichen commented Sep 3, 2019

请问这个修复预计会出现在后续哪个版本的fastjson中？

这几天会发新版本，最晚周末，敬请期待 :)

赞效率！

@Araleii
Copy link
Copy Markdown

Araleii commented Sep 4, 2019

请问处理 \u 的时候是否有类似的问题需要处理呢？

@Omega-Ariston
Copy link
Copy Markdown
Collaborator Author

Omega-Ariston commented Sep 4, 2019

请问处理 \u 的时候是否有类似的问题需要处理呢？

处理\u的时候会调用Integer.parseInt方法，如果输入字符不合要求会抛出NumberFormatException。
不过从可读性考虑的话，是可以加一些简洁的异常提示

@Araleii
Copy link
Copy Markdown

Araleii commented Sep 4, 2019

请问处理 \u 的时候是否有类似的问题需要处理呢？

处理\u的时候会调用Integer.parseInt方法，如果输入字符不合要求会抛出NumberFormatException。
不过从可读性考虑的话，是可以加一些简洁的异常提示

明白了，感谢回复。

@Omega-Ariston
Copy link
Copy Markdown
Collaborator Author

Omega-Ariston commented Sep 7, 2019

有个问题,最新的版本1.26中怎么没有看的这个问题修复的代码

有的，只不过换了写法，不再是函数调用了。

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Omega-Ariston @codecov-io @yeweichen @Araleii @xumingguan @wenshao