Add compatible adapter module for Apache Dubbo 2.7.x and above#619
Merged
CarpenterLee merged 2 commits intomasterfrom Mar 27, 2019
Merged
Add compatible adapter module for Apache Dubbo 2.7.x and above#619CarpenterLee merged 2 commits intomasterfrom
CarpenterLee merged 2 commits intomasterfrom
Conversation
- copied legacy code and adapts to new package - also update document for legacy Dubbo adapter Signed-off-by: Eric Zhao <sczyh16@gmail.com>
…sion Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #619 +/- ##
============================================
+ Coverage 40.31% 40.55% +0.24%
- Complexity 1288 1305 +17
============================================
Files 278 284 +6
Lines 8831 8916 +85
Branches 1183 1192 +9
============================================
+ Hits 3560 3616 +56
- Misses 4811 4833 +22
- Partials 460 467 +7
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Since Apache Dubbo 2.7.0, the package
com.alibaba.dubbohas been transferred toorg.apache.dubbo, which is not compatible with old version. Though Dubbo kept some legacy interfaces, there are still compatibility problems. For Sentinel Dubbo adapter, we have to keep compatible with both Dubbo 2.7.x and previous versions, so I added an additional modulesentinel-apache-dubbo-adapterthat only works for the new versions of Apache Dubbo.Does this pull request fix one issue?
Fixes #496
Describe how you did it
Add a new additional module
sentinel-apache-dubbo-adapterthat only works for the new versions of Apache Dubbo. Legacy adapter is kept for Dubbo 2.6.x version.Describe how to verify it
Run the test cases and demo.
Special notes for reviews
NONE