Merged
Conversation
jannotti
approved these changes
Oct 23, 2025
cce
reviewed
Oct 23, 2025
| func numInnerTxn(txn sdk.SignedTxnWithAD) int { | ||
| result := 0 | ||
| for _, itxn := range txn.ApplyData.EvalDelta.InnerTxns { | ||
| for _, itxn := range txn.EvalDelta.InnerTxns { |
There was a problem hiding this comment.
nit: IMO this makes it harder to read but it's fine. in algorand/go-algorand#6473 i set it to ignore staticcheck QF1008 (this lint warning)
cce
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps Go version from 1.23 to 1.25 and golangci-lint to 2.5 (now executed via
go runrather than expected to be base installed).Various new linter warnings were addressed, and the configuration was migrated to be 2.x compatible.
Test Plan
Existing tests should pass