Bump to updated snapshots of go-algorand-sdk and indexer#182
Merged
gmalouf merged 2 commits intoalgorand:masterfrom Jun 13, 2025
Merged
Bump to updated snapshots of go-algorand-sdk and indexer#182gmalouf merged 2 commits intoalgorand:masterfrom
gmalouf merged 2 commits intoalgorand:masterfrom
Conversation
…filter processors and update tests to reflect stronger basic types.
jannotti
approved these changes
Jun 13, 2025
jannotti
left a comment
There was a problem hiding this comment.
I don't understand the algod_importer stuff, but otherwise seems straightforward.
|
|
||
| assert.Equal(t, 1, len(output.Payset)) | ||
| assert.Equal(t, uint64(2), output.Payset[0].SignedTxnWithAD.ApplicationID) | ||
| assert.Equal(t, sdk.AppIndex(2), output.Payset[0].SignedTxnWithAD.ApplicationID) |
There was a problem hiding this comment.
This is fine, of course, but I sometimes use:
assert.EqualValues(t, 2, output.Payset[0].SignedTxnWithAD.ApplicationID) to avoid the casts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump to updated snapshots of go-algorand-sdk and indexer. Regenerate filter processors and update tests to reflect stronger basic types.
NOTE: We likely have a circular dependency issue in getting the indexer integration tests to pass (this PR depends on a branched snapshot of indexer from the corresponding dependency bump branch) and indexer needs this updated version of Conduit for integration tests to pass.
Test Plan
Existing tests should pass.