Incentives: Bump to v40 consensus supporting development versions of Go SDK and Indexer.#179
Merged
gmalouf merged 2 commits intoalgorand:masterfrom Dec 21, 2024
Merged
Conversation
jannotti
reviewed
Dec 20, 2024
| "dt.lg": true, | ||
| "dt.sa": true, | ||
| // Filter out heartbeat fields that are not obvious how to filter upon | ||
| "txn.hb": true, |
There was a problem hiding this comment.
I have no idea what's going on here, so I'm guessing here. But is seems like the hb address is a worthwhile and understandable field. I guess the rest of the hb fields are not very interesting.
algorandskiy
approved these changes
Dec 20, 2024
algorandskiy
left a comment
There was a problem hiding this comment.
I guess generally there is no interest in heartbeat txns? so LGTM
… can be checked in the filter processor with pre-existing fields.
Contributor
Author
I am happy to add filter processors for heartbeat address if people end up wanting them, but can be follow-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support v40 consensus version and new heartbeat transaction type.
Test Plan
Existing tests should pass.