Set conduit data dir through env var in entrypoint script#154
Merged
winder merged 1 commit intoalgorand:masterfrom Oct 13, 2023
Merged
Set conduit data dir through env var in entrypoint script#154winder merged 1 commit intoalgorand:masterfrom
winder merged 1 commit intoalgorand:masterfrom
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
==========================================
+ Coverage 67.66% 72.89% +5.23%
==========================================
Files 32 38 +6
Lines 1976 2789 +813
==========================================
+ Hits 1337 2033 +696
- Misses 570 646 +76
- Partials 69 110 +41
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
winder
approved these changes
Oct 13, 2023
Contributor
winder
left a comment
There was a problem hiding this comment.
Looks great, thanks for the fix. If you'd like to contribute another PR, the Indexer image is virtually identical to this one. The same fix applies there.
Contributor
Author
|
Yup. Saw it. Was thinking to raise a PR for that as well. Thanks for the merge 🙂 ! |
Contributor
Author
|
Done. algorand/indexer#1583 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
CONDUIT_DATA_DIRin the entrypoint script for docker.