ci: Add gpg signature to checksum file.#150
Merged
winder merged 1 commit intoalgorand:masterfrom Sep 13, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
==========================================
+ Coverage 67.66% 72.89% +5.23%
==========================================
Files 32 38 +6
Lines 1976 2789 +813
==========================================
+ Hits 1337 2033 +696
- Misses 570 646 +76
- Partials 69 110 +41
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
onetechnical
approved these changes
Sep 13, 2023
Contributor
onetechnical
left a comment
There was a problem hiding this comment.
This looks fine for now, though we may want to modify this to do detached sigs as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sign checksum file as part of publishing a release.
The approach here follows a suggestion in the goreleaser docs where the signature is limited to the checksum file.
References:
Repository configuration requires adding the GPG secret and passphrase.
Test Plan
Tested the configuration in a private repo:
https://github.com/algorand/goreleaser-test/releases/tag/untagged-e548c44def7b11988fec