Skip to content

ci: fix release notes template formatting.#148

Merged
winder merged 1 commit intoalgorand:masterfrom
winder:will/fix-goreleaser-template
Sep 1, 2023
Merged

ci: fix release notes template formatting.#148
winder merged 1 commit intoalgorand:masterfrom
winder:will/fix-goreleaser-template

Conversation

@winder
Copy link
Contributor

@winder winder commented Aug 31, 2023

Summary

There were two issues with the new release template:

  • missing forward slash in the diff URL.
  • The triple-dash separator turned the changelog into a header, which was not intentional.

@winder winder requested a review from a team August 31, 2023 19:38
@winder winder self-assigned this Aug 31, 2023
@winder winder requested review from Eric-Warehime, algochoi, shiqizng and tzaffi and removed request for a team August 31, 2023 19:38
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #148 (28ff75e) into master (442791a) will increase coverage by 5.12%.
Report is 58 commits behind head on master.
The diff coverage is 82.54%.

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
+ Coverage   67.66%   72.78%   +5.12%     
==========================================
  Files          32       38       +6     
  Lines        1976     2789     +813     
==========================================
+ Hits         1337     2030     +693     
- Misses        570      649      +79     
- Partials       69      110      +41     
Files Changed Coverage Δ
conduit/data/block_export_data.go 100.00% <ø> (+92.30%) ⬆️
conduit/metrics/metrics.go 100.00% <ø> (ø)
conduit/pipeline/metadata.go 73.52% <ø> (+4.41%) ⬆️
conduit/plugins/config.go 100.00% <ø> (ø)
conduit/plugins/importers/algod/metrics.go 100.00% <ø> (ø)
...gins/processors/filterprocessor/fields/searcher.go 77.50% <ø> (ø)
...ins/processors/filterprocessor/filter_processor.go 83.82% <ø> (+3.54%) ⬆️
...plugins/processors/filterprocessor/gen/generate.go 34.28% <ø> (ø)
conduit/plugins/processors/noop/noop_processor.go 64.70% <ø> (+6.81%) ⬆️
pkg/cli/internal/list/list.go 20.75% <ø> (ø)
... and 22 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder marked this pull request as ready for review September 1, 2023 15:36
@winder winder merged commit 0752d23 into algorand:master Sep 1, 2023
@winder winder deleted the will/fix-goreleaser-template branch September 1, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants