feat(config): Allow options to be passed to algoliasearch#158
feat(config): Allow options to be passed to algoliasearch#158Haroenv merged 3 commits intoalgolia:masterfrom bartdeslagmulder:master
Conversation
…a corporate proxy We're using a corporate proxy and cannot make `gatsby-plugin-algolia` work without passing a custom requester. I found this PR (algolia/algoliasearch-client-javascript#1180) where `createNodeHttpRequester` was extended to pass a custom HTTP agent. With this change you can pass a custom requester to `gatsby-plugin-algolia` which resolved our issue.
|
I think the use case makes sense, but I see two alternatives to this PR:
I prefer both of those options, as they are less likely to need an option per client option, but not sure which of those two is better. Not sure if you have an opinion, but if you could choose one of those two you think fits the best, and also update the readme, I'd accept immediately :) Groetjes! |
|
Tnx for the quick reply @Haroenv! Option 2 would be better as you already require Will try to update today/tomorrow. |
|
That sounds good, thanks! |
|
released in 0.25.0, thanks again! |
|
I started updating the README - but focus shifted on something else and I didn't commit yet. But I saw you did. 👍 |
|
no problem! |
We're using a corporate proxy and cannot make
gatsby-plugin-algoliawork without passing a custom requester.I found this PR (algolia/algoliasearch-client-javascript#1180) where
createNodeHttpRequesterwas extended to pass a custom HTTP agent.With this change you can pass an optional custom requester to
gatsby-plugin-algoliawhich resolved our issue.Feedback is welcome. Let me know if I still need to change/add something.
Thanks in advance!
Bart (from 🇧🇪)