fix(javascript): Update Node options to target ES2018 (#6101)

MarioAlexandruDan · web-flow · commit 1ad4bcd99b57 · 2026-03-13T07:41:17.000+01:00
diff --git a/clients/algoliasearch-client-javascript/base.tsup.config.ts b/clients/algoliasearch-client-javascript/base.tsup.config.ts
@@ -44,11 +44,11 @@ export function getDependencies(pkg: PKG, requester: Requester): string[] {
   }
 }
 
-export function getBaseNodeOptions(pkg: PKG, cwd: string, requester: Requester = 'http'): Options {
+export function getBaseNodeOptions(pkg: PKG, cwd: string, requester: Requester = 'http', target: string = 'node14'): Options {
   return {
     ...getBaseConfig(cwd),
     platform: 'node',
-    target: 'node14',
+    target,
     external: [...getDependencies(pkg, requester), 'node:crypto'],
   };
 }
diff --git a/clients/algoliasearch-client-javascript/packages/client-common/tsup.config.ts b/clients/algoliasearch-client-javascript/packages/client-common/tsup.config.ts
@@ -6,7 +6,7 @@ import pkg from './package.json' with { type: 'json' };
 
 export default defineConfig([
   {
-    ...getBaseNodeOptions(pkg, __dirname),
+    ...getBaseNodeOptions(pkg, __dirname, 'http', 'es2018'),
     format: 'cjs',
     dts: { entry: { common: 'src/index.ts' } },
     entry: { common: 'src/index.ts' },
diff --git a/clients/algoliasearch-client-javascript/packages/logger-console/tsup.config.ts b/clients/algoliasearch-client-javascript/packages/logger-console/tsup.config.ts
@@ -6,7 +6,7 @@ import pkg from './package.json' with { type: 'json' };
 
 export default defineConfig([
   {
-    ...getBaseNodeOptions(pkg, __dirname),
+    ...getBaseNodeOptions(pkg, __dirname, 'http', 'es2018'),
     format: 'cjs',
     dts: { entry: { logger: 'src/logger.ts' } },
     entry: { logger: 'src/logger.ts' },
diff --git a/clients/algoliasearch-client-javascript/packages/requester-fetch/tsup.config.ts b/clients/algoliasearch-client-javascript/packages/requester-fetch/tsup.config.ts
@@ -6,7 +6,7 @@ import pkg from './package.json' with { type: 'json' };
 
 export default defineConfig([
   {
-    ...getBaseNodeOptions(pkg, __dirname),
+    ...getBaseNodeOptions(pkg, __dirname, 'http', 'es2018'),
     format: 'cjs',
     name: 'node cjs',
     entry: { 'requester.fetch.node': 'src/index.ts' },
diff --git a/clients/algoliasearch-client-javascript/packages/requester-node-http/tsup.config.ts b/clients/algoliasearch-client-javascript/packages/requester-node-http/tsup.config.ts
@@ -6,7 +6,7 @@ import pkg from './package.json' with { type: 'json' };
 
 export default defineConfig([
   {
-    ...getBaseNodeOptions(pkg, __dirname),
+    ...getBaseNodeOptions(pkg, __dirname, 'http', 'es2018'),
     format: 'cjs',
     entry: { 'requester.http': 'src/index.ts' },
     dts: { entry: { 'requester.http': 'src/index.ts' } },
diff --git a/clients/algoliasearch-client-javascript/packages/requester-testing/tsup.config.ts b/clients/algoliasearch-client-javascript/packages/requester-testing/tsup.config.ts
@@ -6,7 +6,7 @@ import pkg from './package.json' with { type: 'json' };
 
 export default defineConfig([
   {
-    ...getBaseNodeOptions(pkg, __dirname),
+    ...getBaseNodeOptions(pkg, __dirname, 'http', 'es2018'),
     format: 'cjs',
     entry: { node: 'src/nodeEchoRequester.ts' },
     dts: { entry: { node: 'src/nodeEchoRequester.ts' } },
diff --git a/templates/javascript/clients/tsup.config.mustache b/templates/javascript/clients/tsup.config.mustache
@@ -18,6 +18,7 @@ const nodeConfigs: Options[] = [
   {
     ...nodeOptions,
     format: 'cjs',
+    target: 'es2018',
     name: `node ${pkg.name} cjs`
   },
   {
@@ -47,6 +48,7 @@ const nodeConfigs: Options[] = [
   {
     ...nodeOptions,
     format: 'cjs',
+    target: 'es2018',
     name: 'node algoliasearch cjs',
     dts: { entry: { 'node': 'builds/node.ts' } },
     entry: ['builds/node.ts'],
@@ -141,4 +143,4 @@ const browserConfigs: Options[] = [
   {{/isAlgoliasearchClient}}
 ];
 
-export default defineConfig([...nodeConfigs, ...browserConfigs]);
+export default defineConfig([...nodeConfigs, ...browserConfigs]);

Original file line number	Diff line number	Diff line change
`@@ -44,11 +44,11 @@ export function getDependencies(pkg: PKG, requester: Requester): string[] {`
`44`	`44`	`}`
`45`	`45`	`}`
`46`	`46`
`47`		`-export function getBaseNodeOptions(pkg: PKG, cwd: string, requester: Requester = 'http'): Options {`
	`47`	`+export function getBaseNodeOptions(pkg: PKG, cwd: string, requester: Requester = 'http', target: string = 'node14'): Options {`
`48`	`48`	`return {`
`49`	`49`	`...getBaseConfig(cwd),`
`50`	`50`	`platform: 'node',`
`51`		`- target: 'node14',`
	`51`	`+ target,`
`52`	`52`	`external: [...getDependencies(pkg, requester), 'node:crypto'],`
`53`	`53`	`};`
`54`	`54`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ import pkg from './package.json' with { type: 'json' };`
`6`	`6`
`7`	`7`	`export default defineConfig([`
`8`	`8`	`{`
`9`		`- ...getBaseNodeOptions(pkg, __dirname),`
	`9`	`+ ...getBaseNodeOptions(pkg, __dirname, 'http', 'es2018'),`
`10`	`10`	`format: 'cjs',`
`11`	`11`	`dts: { entry: { common: 'src/index.ts' } },`
`12`	`12`	`entry: { common: 'src/index.ts' },`
Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@ const nodeConfigs: Options[] = [`
`18`	`18`	`{`
`19`	`19`	`...nodeOptions,`
`20`	`20`	`format: 'cjs',`
	`21`	`+ target: 'es2018',`
`21`	`22`	name: `node ${pkg.name} cjs`
`22`	`23`	`},`
`23`	`24`	`{`
`@@ -47,6 +48,7 @@ const nodeConfigs: Options[] = [`
`47`	`48`	`{`
`48`	`49`	`...nodeOptions,`
`49`	`50`	`format: 'cjs',`
	`51`	`+ target: 'es2018',`
`50`	`52`	`name: 'node algoliasearch cjs',`
`51`	`53`	`dts: { entry: { 'node': 'builds/node.ts' } },`
`52`	`54`	`entry: ['builds/node.ts'],`
`@@ -141,4 +143,4 @@ const browserConfigs: Options[] = [`
`141`	`143`	`{{/isAlgoliasearchClient}}`
`142`	`144`	`];`
`143`	`145`
`144`		`-export default defineConfig([...nodeConfigs, ...browserConfigs]);`
	`146`	`+export default defineConfig([...nodeConfigs, ...browserConfigs]);`