test(perso): work around limitations on setPersonalizationStrategy#1179
Merged
test(perso): work around limitations on setPersonalizationStrategy#1179
Conversation
eunjae-lee
approved these changes
Jul 23, 2020
Contributor
eunjae-lee
left a comment
There was a problem hiding this comment.
This fix looks good to me.
I don't have much context (I did read #1178 though), but I feel like this way some test cases will be just skipped randomly (depending on how many times you run it on the day).
Ideally there should be an exception where a specific appId is allowed to call the api unlimittedly.
Contributor
Author
|
There's more context on slack (it's still an expensive operation, even if only for our test application), and we only accept this specific 429 (anything else will still error), so I think this makes the most sense |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1178
Basically the perso API has a limit of 15 calls per day, per application, which will make all tests fail. We prepare ourselves for this now, and also accept the 429 response to be correct