fix(account-client-copy): fixes unhandled promise issue#1154
Merged
nunomaduro merged 5 commits intomasterfrom May 19, 2020
Merged
fix(account-client-copy): fixes unhandled promise issue#1154nunomaduro merged 5 commits intomasterfrom
nunomaduro merged 5 commits intomasterfrom
Conversation
nunomaduro
commented
May 18, 2020
Haroenv
reviewed
May 19, 2020
Co-Authored-By: Haroen Viaene <hello@haroen.me>
Haroenv
reviewed
May 19, 2020
Contributor
Haroenv
left a comment
There was a problem hiding this comment.
I think it's correct now, but can be simplified slightly further.
Co-Authored-By: Haroen Viaene <hello@haroen.me>
Haroenv
previously approved these changes
May 19, 2020
Co-Authored-By: Haroen Viaene <hello@haroen.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue that promises rejections weren't being bubble up to the end-user when calling
accountCopyIndex(source, destination)without anwaitmethod. It also contains some changes related to testing so we can ensure the good behaviour of this pull request.Fixes #1153
accountCopyIndexwith and withoutwaitcalls at the end.accountCopyIndexfails in middle, to make sure it bubbles up the error correctly._metadatafield on getRule.