Skip to content

feat(api-keys): adds ApiKeyACL type#1126

Merged
nunomaduro merged 3 commits intomasterfrom
fix/add-apikeyacl-type
Apr 9, 2020
Merged

feat(api-keys): adds ApiKeyACL type#1126
nunomaduro merged 3 commits intomasterfrom
fix/add-apikeyacl-type

Conversation

@bodinsamuel
Copy link
Copy Markdown

  • Add ApiKeyACL type so we can strictly type the ACL's of api keys

The list can be found here:
https://www.algolia.com/doc/guides/security/api-keys/#rights-acl

@bodinsamuel
Copy link
Copy Markdown
Author

@Ant-hem @aseure nuno asked me to ping you to see if you were interested to have this type in your client's language ☺️

@nunomaduro nunomaduro requested a review from Haroenv April 9, 2020 09:55
@nunomaduro nunomaduro added the TypeScript Problems related to TypeScript definitions label Apr 9, 2020
@nunomaduro
Copy link
Copy Markdown

All tests passing.

Copy link
Copy Markdown
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nunomaduro nunomaduro merged commit 25c98b8 into master Apr 9, 2020
@nunomaduro nunomaduro deleted the fix/add-apikeyacl-type branch April 9, 2020 11:21
@nunomaduro nunomaduro changed the title fix(apiKey): expose ApiKeyACL type feat(api-keys): adds ApiKeyACL type Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

TypeScript Problems related to TypeScript definitions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants