CI: Drop redundant no-default-features from docs and test private items#673
Merged
algesten merged 1 commit intoalgesten:mainfrom Oct 11, 2023
Merged
CI: Drop redundant no-default-features from docs and test private items#673algesten merged 1 commit intoalgesten:mainfrom
no-default-features from docs and test private items#673algesten merged 1 commit intoalgesten:mainfrom
Conversation
Contributor
Author
…tems I added `--all-features` in algesten#670 without removing `--no-default-features` which now has no effect anymore. In addition it is useful to make sure that documentation on private items also adheres to valid intradoc, and somewhat strangely enabling this also causes additional lint warnings on public documentation...
6f74c72 to
12ba1fc
Compare
Owner
|
How would private items interact with I would like us to have |
Contributor
Author
|
@algesten this lint is enforced by Note that if you're doing this, the crate might as well have pass for missing backticks and intradoc links, as I did for one comment in this PR :) |
Owner
|
Alright. Let's do it! |
Contributor
Author
|
Can always revert if it turns out to cause future issues/limitations, but I doubt it 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added
--all-featuresin #670 without removing--no-default-featureswhich now has no effect anymore.In addition it is useful to make sure that documentation on private items also adheres to valid intradoc, and somewhat strangely enabling this also causes additional lint warnings on public documentation...