-
Notifications
You must be signed in to change notification settings - Fork 214
Comparing changes
Open a pull request
base repository: algesten/ureq
base: 2.8.0
head repository: algesten/ureq
compare: 2.9.1
- 16 commits
- 14 files changed
- 5 contributors
Commits on Oct 11, 2023
-
Enable all features in documentation and utilize
doc_auto_cfgTesting all features instead of just a specific set makes it possible for the CI to spot various mistakes in currently-untested doc comments, such as those behind the `http-interop` feature. More importantly, enabling _all features_ on docs.rs as well massively helps visibility in available features and functionality to the end user. And `doc_cfg`/ `doc_auto_cfg` automatically provide them the right information block with a (list of) feature(s) they need to enable to get access to a certain type or function. Note that this requires a `nightly` feature and is hence behind a `--cfg` flag that is only enabled when building for docs.rs (using `nightly`). It can be reproduced locally via `RUSTDOCFLAGS=--cfg=docsrs cargo +nightly doc`. Additionally the CI script is updated to pass `-Dwarnings` to `rustdoc` so that it can adequately fail the CI when incorrect documentation is encountered.
Configuration menu - View commit details
-
Copy full SHA for e2ed110 - Browse repository at this point
Copy the full SHA e2ed110View commit details -
CI: Drop redundant
no-default-featuresfrom docs and test private i……tems I added `--all-features` in #670 without removing `--no-default-features` which now has no effect anymore. In addition it is useful to make sure that documentation on private items also adheres to valid intradoc, and somewhat strangely enabling this also causes additional lint warnings on public documentation...
Configuration menu - View commit details
-
Copy full SHA for d4abcfc - Browse repository at this point
Copy the full SHA d4abcfcView commit details
Commits on Oct 16, 2023
-
Drop redundant or wrong
Requires featuredocumentationAs mentioned in #670 (comment) this sort of documentation is superfluous now that `doc_cfg`/ `doc_auto_cfg` **automatically** generates colored blocks in the documentation denoting what `cfg`s (including features) need to be met in order to enable a symbol. In addition the `http` feature only exists to turn on the `http` crate, while the type conversions in the `http_interop.rs` module are only provided behind the `http-interop` feature. The `charset` feature documentation is left in place, because that affects additional functionality deeper down inside the `send_string()` function.
Configuration menu - View commit details
-
Copy full SHA for 5082bcc - Browse repository at this point
Copy the full SHA 5082bccView commit details
Commits on Oct 17, 2023
-
http_interop: Implement
Requestconversion forhttp::request::PartsI found the current conversion for `http::request::Builder` to be rather useless when the `http` crate and various crates providing `http` interfaces like `oauth2` are designed to provide an `http::Request` directly, and there being no way to convert from a `http::Request` back into its `http::request::Builder`. That, together with strange infallible defaults instead of providing `TryFrom` make the current implementation cumbersome to use. Fortunately `http` provides `http::Request::into_parts()` to get back a `Parts` structure (which is wrapped in `Result<>` inside `http::request::Builder` as sole member!) together with the request body (a generic type) which the user can manually pass to `send_string()`, `send_bytes()` or `call()` if there's no data. Implement a `From<http::request::Parts> for ureq::Request` to support this case, making `ureq` finally capable of sending `http::Request`s. (Note that, despite exclusively consisting of `Result<Parts>`, `http::request::Builder` has no constructor from `Ok(Parts {..})` which would have also facilitated this use-case somewhat)Configuration menu - View commit details
-
Copy full SHA for 3343981 - Browse repository at this point
Copy the full SHA 3343981View commit details
Commits on Oct 23, 2023
-
http_interop: Test that non-UTF-8 sequences in header values are (wro…
…ngly) skipped during conversion
Configuration menu - View commit details
-
Copy full SHA for 6eeb933 - Browse repository at this point
Copy the full SHA 6eeb933View commit details -
http_interop: Remove requirement for header values to be UTF-8
The current interop implementation forces fallibility around header values when they are not UTF-8, both in conversions from `http` to `ureq` as well as the other way around. This should not be necessary as both `http` and `ureq` treat these as opaque byte arrays internally, but unfortunately the current open API for `ureq` and `http` make it a bit nasty to deal with.
Configuration menu - View commit details
-
Copy full SHA for 776e887 - Browse repository at this point
Copy the full SHA 776e887View commit details
Commits on Nov 9, 2023
-
Fix missing add_trust_anchors method due to lax rustls versioning
Upon upgrading to 2.8.0, I got the following compile error from inside `ureq`: error[E0599]: no method named `add_trust_anchors` found for struct `RootCertStore` in the current scope --> /home/cdown/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ureq-2.8.0/src/rtls.rs:102:16 | 102 | root_store.add_trust_anchors(webpki_roots::TLS_SERVER_ROOTS.iter().map(|ta| { | -----------^^^^^^^^^^^^^^^^^ help: there is a method with a similar name: `add_server_trust_anchors` The reason is because `add_trust_anchors` was only added in rustls 0.21.6, but ureq only specifies that any 0.21 is required. As such, if you are already using a compliant, earlier version, the method does not exist and the compile fails. Pin to >=0.21.6 to make sure this method exists. Originally introduced in 50fd1fe ("Update deps").Configuration menu - View commit details
-
Copy full SHA for 916ffbf - Browse repository at this point
Copy the full SHA 916ffbfView commit details
Commits on Nov 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c1bc86a - Browse repository at this point
Copy the full SHA c1bc86aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 07b8925 - Browse repository at this point
Copy the full SHA 07b8925View commit details -
Configuration menu - View commit details
-
Copy full SHA for c83ba95 - Browse repository at this point
Copy the full SHA c83ba95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 260213b - Browse repository at this point
Copy the full SHA 260213bView commit details
Commits on Nov 22, 2023
-
feat: add a feature flag "proxy-from-env" to control whether or not t…
…o detect proxy settings from environment by default
Configuration menu - View commit details
-
Copy full SHA for 395218d - Browse repository at this point
Copy the full SHA 395218dView commit details -
docs: update doc comment on
try_proxy_from_envmethod to reflect th……e `proxy-from-env` feature flag
Configuration menu - View commit details
-
Copy full SHA for 89a69a5 - Browse repository at this point
Copy the full SHA 89a69a5View commit details
Commits on Nov 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 87108e0 - Browse repository at this point
Copy the full SHA 87108e0View commit details -
Rename feature http -> http-crate
In the context of ureq "http" is a bit too generic feature name to use for the http crate interop. Instead we use "http-crate" for the 1.0 dependency.
Configuration menu - View commit details
-
Copy full SHA for 7369043 - Browse repository at this point
Copy the full SHA 7369043View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9092222 - Browse repository at this point
Copy the full SHA 9092222View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 2.8.0...2.9.1