Fix C++ API makefile when compiler is not called g++#28
Merged
Guilucand merged 1 commit intoalgbio:mainfrom Jun 5, 2023
Merged
Fix C++ API makefile when compiler is not called g++#28Guilucand merged 1 commit intoalgbio:mainfrom
Guilucand merged 1 commit intoalgbio:mainfrom
Conversation
Collaborator
|
Hi, thanks for the fix! |
Guilucand
approved these changes
Jun 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building the C++ API fails on systems where the GNU C++ compiler is called something other than g++ (this happens e.g. inside a conda recipe). Replacing the call to g++ with the Makefile environment variable $(CXX) fixes this.