Skip to content

Enable impl_trait_in_assoc_type feature#23

Merged
Guilucand merged 1 commit intoalgbio:mainfrom
jnalanko:main
Apr 26, 2023
Merged

Enable impl_trait_in_assoc_type feature#23
Guilucand merged 1 commit intoalgbio:mainfrom
jnalanko:main

Conversation

@jnalanko
Copy link
Copy Markdown
Contributor

@jnalanko jnalanko commented Apr 20, 2023

The build is currently broken on latest nightly because the feature impl_trait_in_assoc_type has been put behind a feature gate. I am getting errors like:

error[E0658]: `impl Trait` in associated types is unstable
  --> crates/hashes/src/cn_nthash.rs:63:25
   |
63 |       type IteratorType = impl Iterator<
   |  _________________________^
64 | |         Item = <CanonicalNtHashIteratorFactory as HashFunctionFactory>...
65 | |     >;
   | |_____^
   |
   = note: see issue #63063 <https://github.com/rust-lang/rust/issues/63063> for more information
   = help: add `#![feature(impl_trait_in_assoc_type)]` to the crate attributes to enable

This commit fixes these errors.

rchikhi
rchikhi approved these changes Apr 23, 2023
View reviewed changes
Copy link
Copy Markdown

@rchikhi rchikhi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, had the same issue and implemented the same fix. It compiles fine with v1.70.0-nightly, the problem occurs with >= v1.71.0-nighly

@Guilucand Guilucand merged commit 96e72bb into algbio:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rchikhi rchikhi rchikhi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jnalanko @rchikhi @Guilucand