Merged
Conversation
Guilucand
approved these changes
Apr 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The for-loop in AsyncSliceQueue::new pushes only
max_slices_buffers_count-1vectors to the chunks buffers pool. This is a problem at least whenmax_slices_buffers_countis 1, which is the case when the number of threads is 1, in which case nothing is pushed. The function add_data will then get stuck in the inner loop, becauseself.chunks_buffers_pool.1.try_recv()always fails because there is nothing in the pool.