Improve error messages with actionable suggestions #46 by zeel2104 · Pull Request #64 · alexeev-prog/nadzoring

zeel2104 · 2026-03-24T20:18:46Z

Changes include:

Updated cli.py and network-related modules to provide specific guidance when commands fail or permissions are insufficient.
network_base/traceroute.py - suggest installing missing commands or using sudo for permissions.
network_base/whois_lookup.py - suggest installing 'whois' when lookup fails.
arp/cache.py - suggest running as root/sudo if permissions prevent operation.
security/email_security.py - suggest installing dig/dnspython if required.
cli.py - general error handling updated to include actionable guidance in click.ClickException.
Adjusted whois_command docstring in dns_commands.py to fit a single line according to PEP-257 conventions.
Fixed line wrapping in formatters.py to comply with Ruff line-length checks.
Only modified files that were touched during current work.
No changes were made to tests or other legacy code.
All modified files pass Ruff linting checks.

Testing

Tested on google.com and example.com
Verified clean table output in terminal

- Updated cli.py to raise ClickException using 'raise ... from e' for proper exception chaining - Adjusted whois_command docstring in dns_commands.py to fit a single line - Fixed line wrapping in formatters.py to comply with Ruff line-length checks - Only modified files that were touched during current work - All modified files pass Ruff linting checks

alexeev-prog · 2026-03-25T06:58:56Z

Hello! Tabulate is already integrated (see common_cli_options function), just return list with dicts (you can view examples in this dns_commands file) in command and check the result. Commands return a list, as this allows them to be automatically converted to the desired output formats (table, html, csv, json, yaml, toml). You only need to return the files!

alexeev-prog · 2026-03-25T07:00:53Z

And please add comment # type: ignore in import whois line (remove the comment about pip install). This needed for mypy check pass.

alexeev-prog · 2026-03-25T07:05:57Z

@zeel2104 thanks for pr, can you apply changes to code from review?

zeel2104 · 2026-03-25T22:17:31Z

@alexeev-prog
Applied the requested review changes and fixed the failing tests. Local checks are passing now. Please take another look when you have a chance.

zeel2104 · 2026-03-26T00:25:55Z

Hey @alexeev-prog
I’ve done several follow up passes on this PR and addressed the latest review feedback, but I’m still hitting iterative review churn. If it would be more efficient, I’m happy for this to be reassigned to someone more familiar with the project’s preferred structure so it can be finished cleanly. Thank you

alexeev-prog · 2026-03-26T01:18:47Z

@zeel2104 Thanks for your PR!

devin-ai-integration

Devin Review found 1 new potential issue.

View 9 additional findings in Devin Review.

devin-ai-integration · 2026-03-26T01:21:08Z

+    except Exception as e:
+        return [{"error": f"Error fetching WHOIS for {domain}: {e}"}]


🔴 Missing logger.exception() in whois_domain_lookup except block violates mandatory logging rules

The except Exception block at src/nadzoring/network_base/whois_lookup.py:139-140 silently converts the exception to a return value without calling logger.exception(). This violates two mandatory repository rules:

CONTRIBUTING.md: "Use logger.exception(...) inside except blocks" and "Never swallow exceptions silently; always log or re-raise"

.cursor/rules/nadzoring.mdc: "Always use logger.exception() inside except blocks—it automatically captures and includes the traceback"

Every other except block in the same file (whois_lookup.py:67-68) and throughout network_base/ consistently uses logger.exception(). The traceback is lost, making debugging failed WHOIS lookups significantly harder.

Suggested change

except Exception as e:

return [{"error": f"Error fetching WHOIS for {domain}: {e}"}]

except Exception as e:

logger.exception("WHOIS domain lookup failed for %s", domain)

return [{"error": f"Error fetching WHOIS for {domain}: {e}"}]

Was this helpful? React with 👍 or 👎 to provide feedback.

zeel2104 added 2 commits March 24, 2026 15:46

Fix WHOIS table formatting and datetime display

a3df54c

alexeev-prog reviewed Mar 25, 2026

View reviewed changes

alexeev-prog assigned alexeev-prog and zeel2104 and unassigned alexeev-prog Mar 25, 2026