Conversation
Contributor
Author
|
Mm seems like a transitive dependency ( |
Contributor
Author
|
I ended up fixing it by pinning to |
alex
reviewed
Mar 17, 2026
asn1parse/Cargo.toml
Outdated
| # We pin clap to version 4.5.57, which is the last version where both clap | ||
| # and its dependencies have a compatible MSRV. This can be updated once | ||
| # our MSRV is >= 1.85 | ||
| clap = { version = "=4.5.57", features = ["derive"] } |
Owner
There was a problem hiding this comment.
We shouldn't need to use an =, we should pin to the needed versions in ci.yml
We pin clap to version 4.5.61, which is the last version where clap has a compatible MSRV. This can be updated once our MSRV is >= 1.85. We also pin clap_lex, a transitive dependency, since the latest version (1.1.0) also has an incompatible MSRV. Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
alex
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clap4.6.0 was released with a MSRV of 1.85, so we pin until our MSRV is high enough.Motivated by our CI now failing with Rust 1.83.0: log
We pin clap to version 4.5.61, which is the last version where clap
has a compatible MSRV. This can be updated once our MSRV is >= 1.85.
We also pin clap_lex, a transitive dependency, since the latest version
(1.1.0) also has an incompatible MSRV.