Add bit_length() API to BigInt and OwnedBigInt#603
Merged
reaperhulk merged 1 commit intomainfrom Mar 8, 2026
Merged
Conversation
Add a bit_length() method that returns the number of significant bits in the integer's magnitude (absolute value), matching the conventional semantics of Python's int.bit_length(). For non-negative values this strips the 0x00 sign byte and counts significant bits directly. For negative values the magnitude bit count is derived from the two's complement representation by computing bit_length(|x| - 1) and correcting when |x| is a power of two. Tests are table-driven (i64, expected) pairs that round-trip through DER serialization. https://claude.ai/code/session_01B2QqS4ek4j1fDskfSPdLUi
258bf5f to
9dc5083
Compare
reaperhulk
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a bit_length() method that returns the number of significant bits in the integer's magnitude (absolute value), matching the conventional semantics of Python's int.bit_length().
For non-negative values this strips the 0x00 sign byte and counts significant bits directly. For negative values the magnitude bit count is derived from the two's complement representation by computing bit_length(|x| - 1) and correcting when |x| is a power of two.
Tests are table-driven (i64, expected) pairs that round-trip through DER serialization.
https://claude.ai/code/session_01B2QqS4ek4j1fDskfSPdLUi