Add go 1.11.0 by thaJeztah · Pull Request #499 · alecthomas/gometalinter

thaJeztah · 2018-07-04T21:53:42Z

Adding Go 1.11 to travis to catch possible issues; I can update this PR when newer betas are released

thaJeztah · 2018-07-04T22:01:09Z

Alright, looks like there are some failures;

--- FAIL: TestVetShadow (1.46s)
    support.go:51: 
        	Error Trace:	support.go:51
        	            				vet_shadow_test.go:36
        	Error:      	Not equal: 
        	            	expected: regressiontests.Issues{regressiontests.Issue{Linter:"vetshadow", Severity:"warning", Path:"test.go", Line:7, Col:3, Message:"foo declared and not used"}}
        	            	actual  : regressiontests.Issues{regressiontests.Issue{Linter:"vetshadow", Severity:"warning", Path:"test.go", Line:7, Col:3, Message:"foo declared and not used"}, regressiontests.Issue{Linter:"vetshadow", Severity:"warning", Path:"test.go", Line:7, Col:3, Message:"foo declared but not used"}}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,3 +1,4 @@
        	            	-(regressiontests.Issues) (len=1) {
        	            	- (regressiontests.Issue) test.go:7:3:warning: foo declared and not used (vetshadow)
        	            	+(regressiontests.Issues) (len=2) {
        	            	+ (regressiontests.Issue) test.go:7:3:warning: foo declared and not used (vetshadow),
        	            	+ (regressiontests.Issue) test.go:7:3:warning: foo declared but not used (vetshadow)
        	            	 }
        	Test:       	TestVetShadow

edit: TestVet is fixed (was due to different output message)

Details

--- FAIL: TestVet (5.74s)
    vet_test.go:43: 
        	Error Trace:	vet_test.go:43
        	Error:      	Not equal: 
        	            	expected: regressiontests.Issues{regressiontests.Issue{Linter:"vet", Severity:"error", Path:"file.go", Line:7, Col:0, Message:"Printf format %d reads arg #1, but call has only 0 args"}, regressiontests.Issue{Linter:"vet", Severity:"error", Path:"file.go", Line:7, Col:0, Message:"unreachable code"}, regressiontests.Issue{Linter:"vet", Severity:"error", Path:"file_test.go", Line:5, Col:0, Message:"unreachable code"}, regressiontests.Issue{Linter:"vet", Severity:"error", Path:"sub/file.go", Line:7, Col:0, Message:"Printf format %d reads arg #1, but call has only 0 args"}, regressiontests.Issue{Linter:"vet", Severity:"error", Path:"sub/file.go", Line:7, Col:0, Message:"unreachable code"}}
        	            	actual  : regressiontests.Issues{regressiontests.Issue{Linter:"vet", Severity:"error", Path:"file.go", Line:7, Col:0, Message:"Printf format %d reads arg #1, but call has 0 args"}, regressiontests.Issue{Linter:"vet", Severity:"error", Path:"file.go", Line:7, Col:0, Message:"unreachable code"}, regressiontests.Issue{Linter:"vet", Severity:"error", Path:"file_test.go", Line:5, Col:0, Message:"unreachable code"}, regressiontests.Issue{Linter:"vet", Severity:"error", Path:"sub/file.go", Line:7, Col:0, Message:"Printf format %d reads arg #1, but call has 0 args"}, regressiontests.Issue{Linter:"vet", Severity:"error", Path:"sub/file.go", Line:7, Col:0, Message:"unreachable code"}}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,6 +1,6 @@
        	            	 (regressiontests.Issues) (len=5) {
        	            	- (regressiontests.Issue) file.go:7::error: Printf format %d reads arg #1, but call has only 0 args (vet),
        	            	+ (regressiontests.Issue) file.go:7::error: Printf format %d reads arg #1, but call has 0 args (vet),
        	            	  (regressiontests.Issue) file.go:7::error: unreachable code (vet),
        	            	  (regressiontests.Issue) file_test.go:5::error: unreachable code (vet),
        	            	- (regressiontests.Issue) sub/file.go:7::error: Printf format %d reads arg #1, but call has only 0 args (vet),
        	            	+ (regressiontests.Issue) sub/file.go:7::error: Printf format %d reads arg #1, but call has 0 args (vet),
        	            	  (regressiontests.Issue) sub/file.go:7::error: unreachable code (vet)
        	Test:       	TestVet

--- FAIL: TestGas (1.51s)
    gas_test.go:23: 
        	Error Trace:	gas_test.go:23
        	Error:      	Not equal: 
        	            	expected: regressiontests.Issues{regressiontests.Issue{Linter:"gas", Severity:"warning", Path:"file.go", Line:3, Col:0, Message:"Errors unhandled.,LOW,HIGH"}, regressiontests.Issue{Linter:"gas", Severity:"warning", Path:"sub/file.go", Line:3, Col:0, Message:"Errors unhandled.,LOW,HIGH"}}
        	            	actual  : regressiontests.Issues{}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,4 +1,2 @@
        	            	-(regressiontests.Issues) (len=2) {
        	            	- (regressiontests.Issue) file.go:3::warning: Errors unhandled.,LOW,HIGH (gas),
        	            	- (regressiontests.Issue) sub/file.go:3::warning: Errors unhandled.,LOW,HIGH (gas)
        	            	+(regressiontests.Issues) {
        	            	 }
        	Test:       	TestGas
--- PASS: TestDupl (1.10s)
FAIL
FAIL	github.com/alecthomas/gometalinter/regressiontests	34.163s

TestGas looks to be failing because the output is different on go 1.11, and go vet prints messages twice in the output;

output on 1.11

Stderr: 
DEBUG: [Jul  4 23:13:15.501] setenv PATH="/go/bin:/usr/local/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
DEBUG: [Jul  4 23:13:15.527] setenv GOROOT="/usr/local/go"
DEBUG: [Jul  4 23:13:15.527] Current environment:
DEBUG: [Jul  4 23:13:15.527] PATH="/go/bin:/usr/local/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
DEBUG: [Jul  4 23:13:15.527] GOPATH="/go"
DEBUG: [Jul  4 23:13:15.527] GOBIN=""
DEBUG: [Jul  4 23:13:15.527] GOROOT="/usr/local/go"
DEBUG: [Jul  4 23:13:15.530] linting path .
DEBUG: [Jul  4 23:13:15.539] [vetshadow.1]: executing /usr/local/go/bin/go vet --shadow .
DEBUG: [Jul  4 23:13:15.763] [vetshadow.1]: warning: /usr/local/go/bin/go returned exit status 2: # github.com/alecthomas/gometalinter/regressiontests/gometalinter-655212277
./test.go:7:3: foo declared and not used
# github.com/alecthomas/gometalinter/regressiontests/gometalinter-655212277
./test.go:7:3: foo declared but not used
vet: typecheck failures

DEBUG: [Jul  4 23:13:15.763] [vetshadow.1]: vetshadow hits 2: ^(?:vet:.*?\.go:\s+(?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|((?P<path>.*?\.go):(?P<line>\d+):(?P<col>\d+):\s*(?P<message>.*))|(?:(?P<path>.*?\.go):(?P<line>\d+):\s*(?P<message>.*))$
DEBUG: [Jul  4 23:13:15.765] nolint: parsing test.go for directives
DEBUG: [Jul  4 23:13:15.767] [vetshadow.1]: vetshadow linter took 227.61925ms
DEBUG: [Jul  4 23:13:15.767] nolint: parsing test.go took 2.383726ms
DEBUG: [Jul  4 23:13:15.768] total elapsed time 240.62228ms

Output:
[
  {"linter":"vetshadow","severity":"warning","path":"test.go","line":7,"col":3,"message":"foo declared and not used"},
  {"linter":"vetshadow","severity":"warning","path":"test.go","line":7,"col":3,"message":"foo declared but not used"}
]

Difference between 1.10 and 1.11:

1.10

DEBUG: [Jul  4 23:19:47.618] [vetshadow.1]: executing /usr/local/bin/go vet --shadow .
DEBUG: [Jul  4 23:19:47.761] [vetshadow.1]: warning: /usr/local/bin/go returned exit status 2: # github.com/alecthomas/gometalinter/regressiontests/gometalinter-179702599
./test.go:7:3: foo declared and not used

1.11

DEBUG: [Jul  4 23:13:15.539] [vetshadow.1]: executing /usr/local/go/bin/go vet --shadow .
DEBUG: [Jul  4 23:13:15.763] [vetshadow.1]: warning: /usr/local/go/bin/go returned exit status 2: # github.com/alecthomas/gometalinter/regressiontests/gometalinter-655212277
./test.go:7:3: foo declared and not used
# github.com/alecthomas/gometalinter/regressiontests/gometalinter-655212277
./test.go:7:3: foo declared but not used
vet: typecheck failures

thaJeztah · 2018-07-04T23:39:37Z

Ok, so definitely something weird with go vet;

test.go:

package test

type MyStruct struct {}
func test(mystructs []*MyStruct) *MyStruct {
	var foo *MyStruct
	for _, mystruct := range mystructs {
		foo := mystruct
	}
	return foo
}

Go 1.10.3:

 /usr/local/go/bin/go vet --shadow .
# _/foo
./test.go:7:3: foo declared and not used

Go 1.11beta1:

/usr/local/go/bin/go vet --shadow .
# _/foo
./test.go:7:3: foo declared and not used
# _/foo
./test.go:7:3: foo declared but not used
vet: typecheck failures

thaJeztah · 2018-07-04T23:55:45Z

Opened an issue upstream golang/go#26222

thaJeztah · 2018-07-05T06:54:13Z

my issue was marked as a duplicate of golang/go#26125 (which is labeled "release blocker", so should be fixed before Go 1.11 final)

thaJeztah · 2018-07-23T17:15:31Z

Updated to Go 1.11beta2; TestGas is still failing;

=== CONT  TestDupl
--- FAIL: TestGas (1.13s)
    gas_test.go:23: 
        	Error Trace:	gas_test.go:23
        	Error:      	Not equal: 
        	            	expected: regressiontests.Issues{regressiontests.Issue{Linter:"gas", Severity:"warning", Path:"file.go", Line:3, Col:0, Message:"Errors unhandled.,LOW,HIGH"}, regressiontests.Issue{Linter:"gas", Severity:"warning", Path:"sub/file.go", Line:3, Col:0, Message:"Errors unhandled.,LOW,HIGH"}}
        	            	actual  : regressiontests.Issues{}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,4 +1,2 @@
        	            	-(regressiontests.Issues) (len=2) {
        	            	- (regressiontests.Issue) file.go:3::warning: Errors unhandled.,LOW,HIGH (gas),
        	            	- (regressiontests.Issue) sub/file.go:3::warning: Errors unhandled.,LOW,HIGH (gas)
        	            	+(regressiontests.Issues) {
        	            	 }
        	Test:       	TestGas
--- PASS: TestDupl (0.97s)
FAIL

kolyshkin · 2018-07-24T10:21:57Z

Updated to Go 1.11beta2; TestGas is still failing.

This seems to be the problem with a particular linter, gas, which is not part of gometalinter per se.

It looks like gas was renamed to gosec, and its current git tip version (https://github.com/securego/gosec/tree/2785f7aaf8c5236da2412f85e76351123b21b350) correctly detects the error missed by an earlier version. But gometalinter needs some love to switch to this new version, there's an issue for that: #505.

thaJeztah · 2018-07-24T10:25:02Z

@kolyshkin thanks! I arrived at the same conclusion yesterday, and found that PR for the rename; haven't tried yet, but I could temporarily cherry-pick that PR here to check if the latest version resolved the problem

thaJeztah · 2018-07-24T10:30:09Z

cherry-picked #505 into this PR to see if that resolves the issue

thaJeztah · 2018-07-24T11:12:47Z

Looks good! All green with that patch applied

kolyshkin · 2018-07-24T12:27:43Z

I tested manually before, it was working. Heck, I almost created a dupe of #505...

thaJeztah · 2018-08-13T16:05:55Z

Updated to 1.11beta3

kolyshkin · 2018-08-14T08:13:42Z

go 1.11rc1 is out (no docker images as of yet)

wayneashleyberry · 2018-08-14T17:50:14Z

images have been updated to rc1

$ cat Dockerfile
FROM golang:1.11-rc
RUN go version

$ docker build .
Sending build context to Docker daemon  2.048kB
Step 1/2 : FROM golang:1.11-rc
1.11-rc: Pulling from library/golang
55cbf04beb70: Pull complete
1607093a898c: Pull complete
9a8ea045c926: Pull complete
d4eee24d4dac: Pull complete
9c35c9787a2f: Pull complete
a586ab591509: Pull complete
fb94d9d3eaaf: Pull complete
Digest: sha256:848d7c6e26a6ca99bdf50ae952769998f4ffd458328e2f4089ba8e784b09ffd7
Status: Downloaded newer image for golang:1.11-rc
 ---> 798d75db8922
Step 2/2 : RUN go version
 ---> Running in 1a480348c540
go version go1.11rc1 linux/amd64
Removing intermediate container 1a480348c540
 ---> cfa17a33c4fd
Successfully built cfa17a33c4fd

thaJeztah · 2018-08-15T10:49:18Z

Thanks for the ping! Updated the PR to 1.11rc1

robinjoseph08 · 2018-08-27T22:52:59Z

The official 1.11.0 image has also been released if you want to update it to that.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

thaJeztah · 2018-08-28T10:27:32Z

.travis.yml

 go:
 - 1.9.x
 - 1.10.x
+- 1.11


This should be changed to 1.11.x once the first patch release for Go 1.11 is out (erm, unless I remember incorrectly, but I seem to recall .x didn't work if there's no patch release yet)

1.11.x seems to work well for several of my repos, FYI.

There were some problems with Go 1.10, since YAML and some other code parsed 1.10 a a number (1.1), so perhaps that is what you are recalling?

Remember that 1.10 is a JSON number, which is identical to 1.1 -- for an actual 1.10 you want "1.10" to force it to a string!

thaJeztah · 2018-08-28T10:28:54Z

@robinjoseph08 thanks for the ping! I was waiting for those images to arrive indeed, but forgot to update Yesterday 😅

PR is updated, and should be ready for review now

alecthomas · 2018-08-28T10:34:37Z

Thanks!

thaJeztah · 2018-09-01T13:31:46Z

Ah, yes that may have been it!

…

On 1 Sep 2018, at 13:43, Martin Tournoij ***@***.***> wrote: @Carpetsmoker commented on this pull request. In .travis.yml: > @@ -6,6 +6,7 @@ install: go: - 1.9.x - 1.10.x +- 1.11 1.11.x seems to work well for several of my repos, FYI. There were some problems with Go 1.10, since YAML and some other code parsed 1.10 a a number (1.1), so perhaps that is what you are recalling? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

thaJeztah mentioned this pull request Jul 4, 2018

cmd/vet: errors printed twice golang/go#26222

Closed

thaJeztah mentioned this pull request Jul 4, 2018

Bump golang to 1.11.0 moby/moby#37358

Merged

thaJeztah force-pushed the bump_go_1.11 branch from 4b453af to 85414ce Compare July 23, 2018 14:49

kolyshkin mentioned this pull request Jul 24, 2018

Rename gas security checker to gosec #505

Merged

alecthomas mentioned this pull request Jul 25, 2018

Add support for go modules (vgo) #509

Closed

thaJeztah changed the title ~~[do not merge] add go 1.11beta1~~ [do not merge] add go 1.11beta2 Aug 1, 2018

thaJeztah force-pushed the bump_go_1.11 branch from 2dd0aaa to fe3ea80 Compare August 1, 2018 10:27

thaJeztah force-pushed the bump_go_1.11 branch from fe3ea80 to 1f32491 Compare August 13, 2018 16:05

thaJeztah changed the title ~~[do not merge] add go 1.11beta2~~ [do not merge] add go 1.11beta3 Aug 13, 2018

alecthomas mentioned this pull request Aug 13, 2018

Fix installing linters in module-aware environment #518

Closed

thaJeztah force-pushed the bump_go_1.11 branch from 1f32491 to 5a01736 Compare August 15, 2018 10:48

thaJeztah changed the title ~~[do not merge] add go 1.11beta3~~ [do not merge] add go 1.11rc1 Aug 15, 2018

thaJeztah added 2 commits August 28, 2018 12:23

add go 1.11

47d96b2

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Fix TestVet for Go 1.11

5c5c8cd

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

thaJeztah force-pushed the bump_go_1.11 branch from 5a01736 to 5c5c8cd Compare August 28, 2018 10:25

thaJeztah changed the title ~~[do not merge] add go 1.11rc1~~ Add go 1.11.0 Aug 28, 2018

thaJeztah commented Aug 28, 2018

View reviewed changes

alecthomas merged commit 9460458 into alecthomas:master Aug 28, 2018

thaJeztah deleted the bump_go_1.11 branch August 28, 2018 10:52

Conversation

thaJeztah commented Jul 4, 2018

Uh oh!

thaJeztah commented Jul 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thaJeztah commented Jul 4, 2018

Uh oh!

thaJeztah commented Jul 4, 2018

Uh oh!

thaJeztah commented Jul 5, 2018

Uh oh!

thaJeztah commented Jul 23, 2018

Uh oh!

kolyshkin commented Jul 24, 2018

Uh oh!

thaJeztah commented Jul 24, 2018

Uh oh!

thaJeztah commented Jul 24, 2018

Uh oh!

thaJeztah commented Jul 24, 2018

Uh oh!

kolyshkin commented Jul 24, 2018

Uh oh!

thaJeztah commented Aug 13, 2018

Uh oh!

kolyshkin commented Aug 14, 2018

Uh oh!

wayneashleyberry commented Aug 14, 2018

Uh oh!

thaJeztah commented Aug 15, 2018

Uh oh!

robinjoseph08 commented Aug 27, 2018

Uh oh!

thaJeztah Aug 28, 2018

Choose a reason for hiding this comment

Uh oh!

arp242 Sep 1, 2018

Choose a reason for hiding this comment

Uh oh!

dotwaffle Sep 1, 2018

Choose a reason for hiding this comment

Uh oh!

thaJeztah commented Aug 28, 2018

Uh oh!

alecthomas commented Aug 28, 2018

Uh oh!

thaJeztah commented Sep 1, 2018 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

thaJeztah commented Jul 4, 2018 •

edited

Loading