Merged
Conversation
alecthomas
approved these changes
Apr 1, 2024
Owner
|
Lovely, thanks. |
- Allow comments to be inside of tags. - Fixes the lexing of `<!--` comments. - Allow tag names to include `-`. - Modify module rule to be more strict which is to match `declare module "Module name"`. - Added tests. - Resolves alecthomas#940 - Resolves alecthomas#939 - Resolves alecthomas#801
Contributor
Author
|
Too not open too many pull requests, I've added https://github.com/alecthomas/chroma/compare/57c3d2682360547b5b86beee5882a35dd73aa278..829d91f29ba45713e89e15a143455e4755099e83 which resolves #801 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<!--comments.-.declare module "Module name".Input
Before
After