fix(lexers/go): "~" is a valid token#926
Merged
alecthomas merged 2 commits intoalecthomas:masterfrom Feb 12, 2024
abhinav:go-tilde
Merged
fix(lexers/go): "~" is a valid token#926alecthomas merged 2 commits intoalecthomas:masterfrom abhinav:go-tilde
alecthomas merged 2 commits intoalecthomas:masterfrom
abhinav:go-tilde
Conversation
With the introduction of generics, tilde is a valid punctuation token in Go programs. https://go.dev/ref/spec#Operators_and_punctuation This updates the punctuation regex for the Go lexer, and adds a test to ensure that it's treated as such.
alecthomas
reviewed
Feb 12, 2024
Owner
|
Thanks, good catch. |
alecthomas
approved these changes
Feb 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the introduction of generics,
tilde is a valid punctuation token in Go programs.
https://go.dev/ref/spec#Operators_and_punctuation
This updates the punctuation regex for the Go lexer,
and adds a test to ensure that it's treated as such.