Skip to content

Add file extensions to go_template lexer#875

Merged
alecthomas merged 1 commit intoalecthomas:masterfrom
silverwind:gotmpl
Oct 20, 2023
Merged

Add file extensions to go_template lexer#875
alecthomas merged 1 commit intoalecthomas:masterfrom
silverwind:gotmpl

Conversation

@silverwind
Copy link
Contributor

@silverwind silverwind commented Oct 20, 2023

According to this, these two are the most popular.

There is also .gohtml and .go.html but it would need multi-language highlighting. Also, .tmpl is common, but it's already in-use by the cheetah lexer unfortunately.

EOL change is in conformance to editorconfig.

@alecthomas
Copy link
Owner

FYI the Go HTML lexer is here.

@alecthomas alecthomas merged commit 77e9146 into alecthomas:master Oct 20, 2023
@silverwind silverwind deleted the gotmpl branch October 20, 2023 18:00
@silverwind
Copy link
Contributor Author

Ah, then we can add extensions there as well.

@silverwind
Copy link
Contributor Author

silverwind commented Oct 20, 2023

BTW, would you agree to moving .tmpl from cheetah to this? It does not seem very popular:

https://github.com/CheetahTemplate3/cheetah3
https://github.com/cheetahtemplate/cheetah

@alecthomas
Copy link
Owner

They can both have .tmpl but I agree that Go is more popular, so it could have a higher priority.

@silverwind
Copy link
Contributor Author

How does one specify a priority in xml?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants