fix(vue): handle more edge cases for tags #1069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow parsing of attributes to end on `/>`, `>` or a whitespace character. - Consilidate the parsing of the shorthand `@EVENT` to one rule. Do better parsing for its contents by allowing whitespace (`@click="menuVisible = !menuVisible"`) and `EVENT` to contain a dot (`@keyup.enter`). Allow it to not have any condition (`<a @click.stop>`). - Allow `v-` directives to contain a dash. - Move a rule down that captures `v-on:click="doSomething"` as it was included more than it should for the `LiteralString` token. - Add tests that should exhaustively tests these edge cases. They were derived from https://codeberg.org/forgejo/forgejo/src/commit/a18fc8b03702f439845daf22a0cc7fb0f8ea95c3/web_src/js/components/RepoBranchTagSelector.vue#L248-L318
viceice
approved these changes
Apr 18, 2025
BeowulfR
approved these changes
Apr 18, 2025
Owner
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/>,>or a whitespace character.@EVENTto one rule. Do better parsing for its contents by allowing whitespace (@click="menuVisible = !menuVisible") andEVENTto contain a dot (@keyup.enter). Allow it to not have any condition (<a @click.stop>).v-directives to contain a dash.v-on:click="doSomething"as it was included more than it should for theLiteralStringtoken.Screenshot
The syntax highlighting of the input is still not perfect (e.g. HTML comment and
symbol-id=), but it's a lot better now.Before
After