refactor: remove redundant re-sort of styles in chromad

alecthomas · claude · alecthomas · commit a6b9dc755ac6 · 2026-07-05T12:27:16.000+10:00
ctx.Styles is built by iterating styles.Names(), which already
returns names sorted, so the sort.Slice was wasted work.

Co-Authored-By: Claude Fable 5 &lt;noreply@anthropic.com&gt;
diff --git a/cmd/chromad/main.go b/cmd/chromad/main.go
@@ -178,9 +178,6 @@ func newContext(r *http.Request) context {
 			Counterpart: s.Counterpart,
 		})
 	}
-	sort.Slice(ctx.Styles, func(i, j int) bool {
-		return ctx.Styles[i].Name < ctx.Styles[j].Name
-	})
 	return ctx
 }
 

Original file line number	Diff line number	Diff line change
`@@ -178,9 +178,6 @@ func newContext(r *http.Request) context {`
`178`	`178`	`Counterpart: s.Counterpart,`
`179`	`179`	`})`
`180`	`180`	`}`
`181`		`- sort.Slice(ctx.Styles, func(i, j int) bool {`
`182`		`- return ctx.Styles[i].Name < ctx.Styles[j].Name`
`183`		`- })`
`184`	`181`	`return ctx`
`185`	`182`	`}`
`186`	`183`