refactor: remove dead error variable in needRules

alecthomas · claude · alecthomas · commit 3beda6445862 · 2026-07-08T12:06:37.000+10:00
The outer err was never assigned, so the tail return was always
nil; return maybeCompile's result directly.

Co-Authored-By: Claude Fable 5 &lt;noreply@anthropic.com&gt;
diff --git a/regexp.go b/regexp.go
@@ -421,7 +421,6 @@ func (r *RegexLexer) fetchRules() error {
 }
 
 func (r *RegexLexer) needRules() error {
-	var err error
 	if r.fetchRulesFunc != nil {
 		r.compileOnce.Do(func() {
 			r.compileError = r.fetchRules()
@@ -430,10 +429,7 @@ func (r *RegexLexer) needRules() error {
 			return r.compileError
 		}
 	}
-	if err := r.maybeCompile(); err != nil {
-		return err
-	}
-	return err
+	return r.maybeCompile()
 }
 
 // Tokenise text using lexer, returning an iterator.

Original file line number	Diff line number	Diff line change
`@@ -421,7 +421,6 @@ func (r *RegexLexer) fetchRules() error {`
`421`	`421`	`}`
`422`	`422`
`423`	`423`	`func (r *RegexLexer) needRules() error {`
`424`		`- var err error`
`425`	`424`	`if r.fetchRulesFunc != nil {`
`426`	`425`	`r.compileOnce.Do(func() {`
`427`	`426`	`r.compileError = r.fetchRules()`
`@@ -430,10 +429,7 @@ func (r *RegexLexer) needRules() error {`
`430`	`429`	`return r.compileError`
`431`	`430`	`}`
`432`	`431`	`}`
`433`		`- if err := r.maybeCompile(); err != nil {`
`434`		`- return err`
`435`		`- }`
`436`		`- return err`
	`432`	`+ return r.maybeCompile()`
`437`	`433`	`}`
`438`	`434`
`439`	`435`	`// Tokenise text using lexer, returning an iterator.`