perf(colour): replace Sprintf/ParseUint round-trip in NewColour with direct bit arithmetic (#1274)

b-wulan · web-flow · commit 180ea9f54dce · 2026-05-26T07:38:19.000Z
diff --git a/colour.go b/colour.go
@@ -52,7 +52,7 @@ type Colour int32
 
 // NewColour creates a Colour directly from RGB values.
 func NewColour(r, g, b uint8) Colour {
-	return ParseColour(fmt.Sprintf("%02x%02x%02x", r, g, b))
+	return Colour(int32(r)<<16|int32(g)<<8|int32(b)) + 1
 }
 
 // Distance between this colour and another.

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ type Colour int32`
`52`	`52`
`53`	`53`	`// NewColour creates a Colour directly from RGB values.`
`54`	`54`	`func NewColour(r, g, b uint8) Colour {`
`55`		`- return ParseColour(fmt.Sprintf("%02x%02x%02x", r, g, b))`
	`55`	`+ return Colour(int32(r)<<16\|int32(g)<<8\|int32(b)) + 1`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`// Distance between this colour and another.`