Bump glutin to 0.29.0 by kchibisov · Pull Request #6079 · alacritty/alacritty

kchibisov · 2022-05-23T01:45:44Z

Fixes #5975.
Fixes #5767.

kchibisov · 2022-06-12T18:30:12Z

@sshock could you verify that tab issue you've mentioned in winit rust-windowing/winit#2238 gets resolved with this patch? I'm not sure what to look for myself on macOS for that...

chrisduerr · 2022-06-12T21:52:53Z

CHANGELOG.md

 - OSC 52 is now disabled on unfocused windows
 - `SpawnNewInstance` no longer inherits initial `--command`
+- Client side decorations should have proper text rendering now on Wayland
+- Search bar is now respecting cursor thickness


Not sure this should be fixed in this PR?

It's a part of IME commit.

chrisduerr · 2022-06-12T21:53:58Z

CHANGELOG.md

+- Incorrect built-in glyphs for `U+2567` and `U+2568`
+- Cursor not hiding on GNOME Wayland
+- Font having different scale factor after monitor powering off/on on X11
+- Wrong mouse input when opening a new tabbed window on macOS


Rather than describing the mouse part here, I'd instead mention that the entire window content was offset. It affected rendering too, even with no mouse usage.

alacritty.yml

alacritty/build.rs

sshock · 2022-06-13T00:30:19Z

@sshock could you verify that tab issue you've mentioned in winit rust-windowing/winit#2238 gets resolved with this patch? I'm not sure what to look for myself on macOS for that...

Yep, it's working!

kchibisov · 2022-07-27T00:49:45Z

@chrisduerr I've removed IME commit for now and implemented it like we had before. Will rewrite it and send separately.

~~Note, that I have bumped msrv to 1.61 for now. Probably will sort that stuff out tomorrow, since it'll require a winit bump to downgrade it back to 1.57.~~

MSRV issue got resolved.

alacritty/Cargo.toml

alacritty/src/event.rs

alacritty/src/main.rs

chrisduerr · 2022-08-02T20:20:23Z

alacritty/src/main.rs

+    let exit_code = match result {
+        Ok(code) => code,
+        Err(err) => {
+            eprintln!("Error: {}", err);
+            EXIT_FAILURE
+        },
+    };


Why bother with exit codes and all that stuff when Err(err) is mapped to an exit code anyway? Just so we don't print the error?

The idea was to propagate the error code from the event loop somehow, since now run_return will return non zero code in case of failures.

I basically wanted to indicate an error with non zero exit status nothing more. If you have an idea on how to handle that more reliably let me know.

Why not return the actual error? That seems to be the sensible choice to me.

chrisduerr

See my comment about returning a Result.

chrisduerr · 2022-08-07T06:38:08Z

alacritty/src/main.rs

 use crate::macos::locale;

-fn main() {
+fn main() -> Result<(), Box<dyn Error>> {


I've only ever gotten extremely poor results from doing this. I don't think it's a great idea?

I think that's fine, like it'll print error? At least that's how I've parsed your lets return Result, but now I see that you wanted to return it from run_return, but you can't do that.

I'm not sure that this is any different than then println and then exit that what it should do anyway, no?

Hm, I think my main issue with last time I tried it is that you don't get any backtrace by doing this. Which should be fine in our case since we were just using println anyway.

chrisduerr · 2022-08-07T06:42:18Z

alacritty/src/event.rs

+                        // Stash the error and exit with non-zero code.
+                        *loop_error.lock().unwrap() = result.into();
+                        *control_flow = ControlFlow::ExitWithCode(1);
+                        return;


Wait can we not just exit with any generic result, which is then returned from the closure?! That's kinda garbage.

Let's maybe just print the error directly inside the run_return, then exit upwards with just any random error text?

I definitely don't want to throw mutexes at a silly one-off error that can only happen right before the event loop crashes anyway.

We can, sure.

chrisduerr

I think it would be nice to have the ability to return from winit's run_return with any type parameter, but this should be fine for now.

chrisduerr · 2022-08-10T07:23:10Z

alacritty/src/main.rs

 use crate::macos::locale;

-fn main() {
+fn main() -> Result<(), Box<dyn Error>> {


Hm, I think my main issue with last time I tried it is that you don't get any backtrace by doing this. Which should be fine in our case since we were just using println anyway.

Fixes alacritty#6239. Fixes alacritty#5975. Fixes alacritty#5876. Fixes alacritty#5767. Fixes alacritty#4484. Fixes alacritty#3139.

kchibisov added the C - waiting on dependency label May 23, 2022

kchibisov force-pushed the update-winit-0.27 branch 2 times, most recently from 6b774ad to 8a53967 Compare May 25, 2022 06:03

kchibisov mentioned this pull request May 31, 2022

ugly alacritty with default ubuntu 22.04 window manager #6094

Closed

kchibisov force-pushed the update-winit-0.27 branch 2 times, most recently from e6ea4ab to 961c562 Compare June 1, 2022 20:36

This was referenced Jun 1, 2022

Feature request, no borders but title bar #6100

Closed

Multiple windows aren't properly resized on Wayland #6069

Closed

kchibisov force-pushed the update-winit-0.27 branch from 961c562 to 6c9fa5c Compare June 4, 2022 16:00

kchibisov added this to the Version 0.11.0 milestone Jun 4, 2022

kchibisov mentioned this pull request Jun 4, 2022

Add inline input method support #5790

Closed

kchibisov force-pushed the update-winit-0.27 branch from 6c9fa5c to 0bc5047 Compare June 10, 2022 11:57

kchibisov requested a review from chrisduerr June 10, 2022 11:58

kchibisov force-pushed the update-winit-0.27 branch 2 times, most recently from 2a60dbe to 2b03e4e Compare June 10, 2022 12:43

kchibisov mentioned this pull request Jun 10, 2022

Reopening Terminal #5975

Closed

kchibisov force-pushed the update-winit-0.27 branch 4 times, most recently from d3bd9a6 to 6b32bca Compare June 12, 2022 19:46

chrisduerr requested changes Jun 12, 2022

View reviewed changes

kchibisov mentioned this pull request Jun 13, 2022

Don't load disabled fonts on macOS alacritty/crossfont#46

Merged

kchibisov force-pushed the update-winit-0.27 branch 3 times, most recently from 35b7ef5 to accad57 Compare June 13, 2022 17:41

kchibisov mentioned this pull request Jun 16, 2022

MacOS: key binding for Command-Q not working after upgrade from 0.9.0 to 0.10.0 #6136

Open

kchibisov force-pushed the update-winit-0.27 branch 2 times, most recently from a3a26dc to 0509425 Compare June 20, 2022 09:39

kchibisov mentioned this pull request Jul 3, 2022

On macOS and X11 do not render when the window is occluded for performance #6177

Merged

kchibisov force-pushed the update-winit-0.27 branch 3 times, most recently from df75b81 to 15a9dc7 Compare July 12, 2022 15:14

kchibisov force-pushed the update-winit-0.27 branch from 15a9dc7 to 8fe31e8 Compare July 27, 2022 00:33

kchibisov removed the C - waiting on dependency label Jul 27, 2022

kchibisov requested a review from chrisduerr July 27, 2022 00:37

kchibisov marked this pull request as ready for review July 27, 2022 00:37

kchibisov changed the title ~~[WIP] Bump winit to 0.27.0~~ Bump glutin to 0.29.0 Jul 27, 2022

kchibisov force-pushed the update-winit-0.27 branch from 8fe31e8 to c5a0fd0 Compare July 27, 2022 00:40

kchibisov commented Jul 27, 2022

View reviewed changes

alacritty/Cargo.toml Outdated Show resolved Hide resolved

kchibisov force-pushed the update-winit-0.27 branch 2 times, most recently from 15d0236 to 190ba88 Compare July 30, 2022 21:37

chrisduerr requested changes Aug 2, 2022

View reviewed changes

kchibisov mentioned this pull request Aug 4, 2022

Mouse pointer no longer hiding when typing #6239

Closed

kchibisov force-pushed the update-winit-0.27 branch 2 times, most recently from 1f3136c to 826ab98 Compare August 5, 2022 08:29

kchibisov requested a review from chrisduerr August 5, 2022 08:31

kchibisov force-pushed the update-winit-0.27 branch from 826ab98 to 6000cc9 Compare August 5, 2022 12:24

chrisduerr requested changes Aug 5, 2022

View reviewed changes

kchibisov requested a review from chrisduerr August 6, 2022 20:17

kchibisov force-pushed the update-winit-0.27 branch from 6df4a48 to 1e90ade Compare August 6, 2022 20:22

chrisduerr requested changes Aug 7, 2022

View reviewed changes

kchibisov requested a review from chrisduerr August 7, 2022 18:44

chrisduerr approved these changes Aug 10, 2022

View reviewed changes

Bump glutin to 0.29.1

bda4889

Fixes alacritty#6239. Fixes alacritty#5975. Fixes alacritty#5876. Fixes alacritty#5767. Fixes alacritty#4484. Fixes alacritty#3139.

kchibisov force-pushed the update-winit-0.27 branch from 700bcc1 to bda4889 Compare August 10, 2022 12:34

kchibisov merged commit 7d708d5 into alacritty:master Aug 10, 2022

kchibisov deleted the update-winit-0.27 branch August 10, 2022 12:48

Conversation

kchibisov commented May 23, 2022 • edited by chrisduerr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kchibisov commented Jun 12, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sshock commented Jun 13, 2022

Uh oh!

kchibisov commented Jul 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chrisduerr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kchibisov Aug 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chrisduerr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

kchibisov commented May 23, 2022 •

edited by chrisduerr

Loading

kchibisov commented Jul 27, 2022 •

edited

Loading

kchibisov Aug 7, 2022 •

edited

Loading