Add fallback GLES2 renderer#5902
Merged
chrisduerr merged 7 commits intoalacritty:masterfrom Mar 2, 2022
Merged
Conversation
d563687 to
b0eae8a
Compare
Member
Author
|
Blocked on #5904 |
2753824 to
6ac43df
Compare
kchibisov
commented
Feb 22, 2022
README.md
Outdated
| ### Requirements | ||
|
|
||
| - OpenGL 3.3 or higher | ||
| - OpenGL ES 2.0 or higher |
Member
Author
There was a problem hiding this comment.
I'm not sure how to adjust it, since I have a feeling that OpenGL 2.1 device without gles2 won't work, since shaders are gles2. Though it's a matter of adjusting syntax in shaders.
Member
There was a problem hiding this comment.
Should be almost irrelevant at that point. But GLES2 support might suffice?
411c73a to
73df60f
Compare
Member
Author
|
This is ready for review. The feature parity with glsl3 render was reached, fallback stratagy and shaders reuse were added. |
327745b to
6eb6b8c
Compare
Member
|
|
Member
|
|
chrisduerr
requested changes
Feb 26, 2022
Member
chrisduerr
left a comment
There was a problem hiding this comment.
I'll take a look at gles2.rs/gles3.rs and the gles2 shaders later, but the rest of the code looks pretty good already.
Member
|
|
Closed
Member
|
|
This commit adds a fallback GLES2 renderer for platforms not supporting OpenGL 3.3 providing ability to run Alacritty on those. While its performance is slightly slower than glsl3 version it's way faster than software rendering with software emulated GL (e.g. llvmpipe), since that's what Alacritty used on platforms not supporting required OpenGL version. Fixes alacritty#128.
chrisduerr
requested changes
Feb 28, 2022
chrisduerr
requested changes
Mar 2, 2022
Member
chrisduerr
left a comment
There was a problem hiding this comment.
I think this might be good to go.
chrisduerr
approved these changes
Mar 2, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a fallback GLES2 renderer for platforms not supporting
OpenGL 3.3 providing ability to run alacritty on those. While its
performance is slightly slower than glsl3 version it's way faster than
software rendering with sofware emulated GL (e.g. llvmpipe), since
that's what alacritty used on platforms not supporting required OpenGL
version.
Fixes #128.
--
I've managed to run it on pi without any issues.