Use winit's new clipboard API instead of copypasta#5793
Use winit's new clipboard API instead of copypasta#5793kchibisov wants to merge 1 commit intoalacritty:masterfrom
copypasta#5793Conversation
This commit makes alacritty use new winit clipboard API instead of relying on copypasta provider, which proved to be poor option when it comes to performance and stability. Fixes alacritty#5050. Fixes alacritty#3601. Fixes alacritty#3108. Fixes alacritty#2811. Fixes alacritty#2735. Fixes alacritty#2453.
| mimes.insert(String::from("text/plain;charset=utf-8")); | ||
| mimes.insert(String::from("text/plain")); | ||
| mimes.insert(String::from("UTF8_STRING")); |
There was a problem hiding this comment.
I feel like it might be convenient for winit to do this for me? Chances are these mimes are going to be very common.
Maybe either a set_text function or some helper to get the "normal text" mimes?
There was a problem hiding this comment.
Mime types are hard since you need a strategy to pick one of offered and provide your data with mime type you've offered. For example you can serve image and text at the same time. So you need a callback to decide how to represent your data.
There was a problem hiding this comment.
Yeah, winit could provide a helpers for mime type handling. Im just not sure how they should look.
There was a problem hiding this comment.
I just feel like the majority of clients will likely always write text only.
|
|
|
hello, just wondering if there's any chance this could make it into version 0.12.0? |
This one for sure no, it's a prototype for me to simplify testing stuff upstream. It'll be implemented eventually, it'll just require a lot of effort, and not only from my side to finish(need to implement Wayland, X11, macOS, windows, and I can really provide Wayland only)... |
|
Lots of said issues were fixed already on master and winit will have its clipboard API not really soon. |
This commit makes alacritty use new winit clipboard API instead of
relying on copypasta provider, which proved to be poor option when it
comes to performance and stability.
Fixes #5050.
Fixes #3601.
Fixes #3108.
Fixes #2811.
Fixes #2735.
Fixes #2453.