Skip to content

Fix build errors on BSD#2253

Merged
chrisduerr merged 2 commits intoalacritty:masterfrom
chrisduerr:bsd-build-fix
Apr 4, 2019
Merged

Fix build errors on BSD#2253
chrisduerr merged 2 commits intoalacritty:masterfrom
chrisduerr:bsd-build-fix

Conversation

@chrisduerr
Copy link
Copy Markdown
Member

@chrisduerr chrisduerr commented Apr 4, 2019

This updates winit and glutin to the latest git versions instead of
relying on releases to fix a build failure on BSD.

Unfortunately the upstream version bumps might still take a bit and
there hasn't been any feedback with regards to a planned release date.

This also fixes a slight issue on Windows where selections would start
when focusing a window and a build failure with some Linux systems

Fixes #2243.
Fixes #2170.
Fixes #2244.

@chrisduerr
Fix build errors on BSD
338d679 
This updates winit and glutin to the latest git versions instead of
relying on releases to fix a build failure on BSD.

Unfortunately the upstream version bumps might still take a bit and
there hasn't been any feedback with regards to a planned release date.

This also fixes a slight issue on Windows where selections would start
when focusing a window and a build failure with some Linux systems

Fixes alacritty#2243.
Fixes alacritty#2170.
Fixes alacritty#2244.
@chrisduerr chrisduerr added this to the Version 0.3.0 milestone Apr 4, 2019
This was referenced Apr 4, 2019
Closed
Closed
@chrisduerr chrisduerr merged commit f0dbfc9 into alacritty:master Apr 4, 2019
@doubleloop
Copy link
Copy Markdown

doubleloop commented Apr 5, 2019 •
edited
Loading

I just compiled f0dbfc9, unfortunately it produces segfault, here is stack trace:

$ gdb target/debug/alacritty
Reading symbols from target/debug/alacritty...done.
warning: Missing auto-load script at offset 0 in section .debug_gdb_scripts
of file /home/doubleloop/src/alacritty/target/debug/alacritty.
Use `info auto-load python-scripts [REGEXP]' to list them.
(gdb) run
Starting program: /home/doubleloop/src/alacritty/target/debug/alacritty
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff772effd in XQueryExtension () from /usr/lib/x86_64-linux-gnu/libX11.so.6
(gdb) backtrace
#0  0x00007ffff772effd in XQueryExtension () from /usr/lib/x86_64-linux-gnu/libX11.so.6
#1  0x00007ffff7722936 in XInitExtension () from /usr/lib/x86_64-linux-gnu/libX11.so.6
#2  0x00007ffff6aa40df in XextAddDisplay () from /usr/lib/x86_64-linux-gnu/libXext.so.6
#3  0x00007ffff5c8a197 in ?? () from /usr/lib/x86_64-linux-gnu/libGL.so.1
#4  0x00007ffff5c8a1ea in ?? () from /usr/lib/x86_64-linux-gnu/libGL.so.1
#5  0x00007ffff5c8a8fa in ?? () from /usr/lib/x86_64-linux-gnu/libGL.so.1
#6  0x00007ffff5c8c3ea in ?? () from /usr/lib/x86_64-linux-gnu/libGL.so.1
#7  0x000055555601bf29 in glutin_glx_sys::glx::Glx::MakeCurrent (
    self=0x5555567dfee8 <<glutin::api::glx::GLX as core::ops::deref::Deref>::deref::__stability::LAZY>,
    dpy=0x0, drawable=0, ctx=0x0)
    at /home/doubleloop/src/alacritty/target/debug/build/glutin_glx_sys-c9bb70a96d1663b6/out/glx_bindings.rs:545
#8  0x000055555601fade in <glutin::api::glx::make_current_guard::MakeCurrentGuard as core::ops::drop::Drop>::drop (self=0x7fffffff0630)
    at /home/doubleloop/.cargo/git/checkouts/glutin-f805f5db31188ce2/ea545cb/glutin/src/api/glx/make_current_guard.rs:69
#9  0x00005555560152a5 in core::ptr::real_drop_in_place ()
    at /rustc/2aa4c46cfdd726e97360c2734835aa3515e8c858/src/libcore/ptr.rs:193
#10 0x000055555600098e in glutin::api::glx::ContextPrototype::finish (self=..., win=48234499)
    at /home/doubleloop/.cargo/git/checkouts/glutin-f805f5db31188ce2/ea545cb/glutin/src/api/glx/mod.rs:435
#11 0x0000555555993d7f in glutin::platform::platform::x11::Context::new (wb=..., el=0x7fffffff3d88,
    pf_reqs=0x7fffffff2980, gl_attr=0x7fffffff2698)
    at /home/doubleloop/.cargo/git/checkouts/glutin-f805f5db31188ce2/ea545cb/glutin/src/platform/linux/x11.rs:189
#12 0x000055555598cb5d in glutin::platform::platform::Context::new_windowed (wb=..., el=0x7fffffff3d88,
    pf_reqs=0x7fffffff2980, gl_attr=0x7fffffff29c8)
    at /home/doubleloop/.cargo/git/checkouts/glutin-f805f5db31188ce2/ea545cb/glutin/src/platform/linux/mod.rs:116
#13 0x0000555555962061 in glutin::windowed::<impl glutin::ContextBuilder<'a, T>>::build_windowed (
    self=..., wb=..., el=0x7fffffff3d88)
    at /home/doubleloop/.cargo/git/checkouts/glutin-f805f5db31188ce2/ea545cb/glutin/src/windowed.rs:186
#14 0x00005555558bd9e1 in alacritty::window::create_gl_window (window=..., event_loop=0x7fffffff3d88,
    srgb=false) at src/window.rs:123
#15 0x00005555558be0b1 in alacritty::window::Window::new (options=0x7fffffffc4b8,
    window_config=0x7fffffffcdf8) at src/window.rs:145
#16 0x00005555557a42f5 in alacritty::display::Display::new (config=0x7fffffffccb8, options=0x7fffffffc4b8)
    at src/display.rs:141
#17 0x000055555570ef32 in alacritty::run (config=..., options=0x7fffffffc4b8, message_buffer=...)
    at src/main.rs:136
#18 0x000055555570e30c in alacritty::main () at src/main.rs:104
(gdb)

note: I also verified that on the referenced glutin bsd-build-fix branch (chrisduerr/glutin@ea545cb) example window works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

Version 0.3.0

Development

Successfully merging this pull request may close these issues.

Build failure on OpenBSD Alacritty v0.3.0-rc2 does not start (Error creating GL context) Windows: Focus with mouse highlights text

2 participants

@chrisduerr @doubleloop