outlet/routing: buffer BMP messages to avoid being flagged as "stuck"#2245
Merged
Conversation
46549ef to
b1d7212
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2245 +/- ##
==========================================
- Coverage 84.94% 84.83% -0.11%
==========================================
Files 231 231
Lines 13963 14029 +66
==========================================
+ Hits 11861 11902 +41
- Misses 1401 1421 +20
- Partials 701 706 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b1d7212 to
d13f504
Compare
When flushing RIBs or receiving a big update, some BMP receivers may not process the packets in a timely fashion and may be flagged as stuck, closing the connection. The workaround was to increase the kernel buffer. Instead, we separate BMP message processing into a goroutine for I/O processing and a goroutine for handling received messages, with a configurable buffered channels between them. Fix #2092 This may be better than #2244 as performance may be better (but no benchmark for that).
Also: - preinitialize some metrics - curry some metrics (better performance)
d13f504 to
6cc9dd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When flushing RIBs or receiving a big update, some BMP receivers may not process the packets in a timely fashion and may be flagged as stuck, closing the connection. The workaround was to increase the kernel buffer.
Instead, we separate BMP message processing into a goroutine for I/O processing and a goroutine for handling received messages, with a configurable buffered channels between them.
Fix #2092
This may be better than #2244 as performance may be better (but no benchmark for that).